diff options
| author | Martin Roth <gaumless@gmail.com> | 2015-06-28 09:44:31 -0600 |
|---|---|---|
| committer | Martin Roth <gaumless@gmail.com> | 2015-07-12 19:05:28 +0200 |
| commit | ba566bdc8b451a9b6906359c2cea2df1eaebe8ee (patch) | |
| tree | 0fe5af3e067084e79725877a3d8a0afbe582474a | |
| parent | 3a391fd20cb1ec9a5677832ee338639e95d6757a (diff) | |
| download | coreboot-ba566bdc8b451a9b6906359c2cea2df1eaebe8ee.tar.gz coreboot-ba566bdc8b451a9b6906359c2cea2df1eaebe8ee.tar.bz2 coreboot-ba566bdc8b451a9b6906359c2cea2df1eaebe8ee.zip | |
southbridge/amd/pi/hudson: Fix HUDSON_DISABLE_IMC kconfig warning
Platforms selecting the HUDSON_DISABLE_IMC symbol were showing the
warning:
warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS &&
CPU_AMD_AGESA_BINARY_PI) selects HUDSON_DISABLE_IMC which has unmet
direct dependencies (SOUTHBRIDGE_AMD_PI_AVALON ||
SOUTHBRIDGE_AMD_PI_BOLTON || SOUTHBRIDGE_AMD_PI_KERN)
By moving the definition of the symbol outside of the if block
and removing the default n, we can get rid of the warning without
changing the value for any platform.
Change-Id: I5c1bdfbcf3c5c44ee05b8c5e679f6854d784d8dc
Signed-off-by: Martin Roth <gaumless@gmail.com>
Reviewed-on: http://review.coreboot.org/10680
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Idwer Vollering <vidwer@gmail.com>
| -rw-r--r-- | src/southbridge/amd/pi/hudson/Kconfig | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/southbridge/amd/pi/hudson/Kconfig b/src/southbridge/amd/pi/hudson/Kconfig index 36716fab0f68..237183ab8833 100644 --- a/src/southbridge/amd/pi/hudson/Kconfig +++ b/src/southbridge/amd/pi/hudson/Kconfig @@ -35,6 +35,9 @@ config SOUTHBRIDGE_AMD_PI_KERN select HAVE_USBDEBUG_OPTIONS select HAVE_HARD_RESET +config HUDSON_DISABLE_IMC + bool + if SOUTHBRIDGE_AMD_PI_AVALON || SOUTHBRIDGE_AMD_PI_BOLTON || SOUTHBRIDGE_AMD_PI_KERN config BOOTBLOCK_SOUTHBRIDGE_INIT @@ -65,10 +68,6 @@ config HUDSON_XHCI_FWM help Add Hudson 2/3/4 XHCI Firmware to support the onboard USB 3.0 -config HUDSON_DISABLE_IMC - bool - default n - config HUDSON_IMC_FWM bool "Add IMC firmware" depends on !HUDSON_DISABLE_IMC |