diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2019-07-17 10:36:10 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2019-07-19 16:43:27 +0000 |
| commit | 0bbb0fcf5ff16061ae7b5f182a5803020df65c9a (patch) | |
| tree | 75e182c6d3ed84ac1c1cec98d7da3764cb776264 | |
| parent | 1d3489445bdbbbe87147c9276d2022f1e58c6859 (diff) | |
| download | coreboot-0bbb0fcf5ff16061ae7b5f182a5803020df65c9a.tar.gz coreboot-0bbb0fcf5ff16061ae7b5f182a5803020df65c9a.tar.bz2 coreboot-0bbb0fcf5ff16061ae7b5f182a5803020df65c9a.zip | |
google/nocturne: Add MKBP events as a wake source
We would like to wake nocturne up in suspend from an MKBP event. On
Nocturne, MKBP events are notified to the host via a GPIO from the EC,
EC_INT_L. However, the AP cannot wake from suspend from this GPIO.
Therefore, we'll use the host event interface to wake the system
instead.
This commit simply enables MKBP events to wake the system in suspend.
BUG=chromium:786721
BRANCH=firmware-nocturne-10984.B
TEST=Build and flash nocturne, generate MKBP events on the EC and verify
that the system wakes up in suspend.
Change-Id: I6aff4d38051c939257533229fd0085e42c01d02f
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34388
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
| -rw-r--r-- | src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h index 46e848b710c8..dfb0f7449ea4 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h @@ -48,6 +48,7 @@ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) #define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS) |