summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJonathan Zhang <jonzhang@fb.com>2020-08-17 15:22:54 -0700
committerAngel Pons <th3fanbus@gmail.com>2020-08-24 09:17:25 +0000
commit6a7531431d1f9a8225529fc7b71ab57e0da984c3 (patch)
tree0e5a42470d794c903a9676572259df5fa2401b37
parentaae448601c0679171d711a70a03bcfe52b4accf3 (diff)
downloadcoreboot-6a7531431d1f9a8225529fc7b71ab57e0da984c3.tar.gz
coreboot-6a7531431d1f9a8225529fc7b71ab57e0da984c3.tar.bz2
coreboot-6a7531431d1f9a8225529fc7b71ab57e0da984c3.zip
mb/facebook/watson: increase size of RO_VPD and RW_VPD
The current size of RO_VPD (and RW_VPD) is too small. We have case that adding VPD parameters silently corrupts the coreboot region next to RO_VPD. Increase the size of both RO_VPD and RW_VPD to 0x4000 bytes. TESTED=build coreboot image for watson, add large size VPD parameter to the image, boot watson server into target OS. Signed-off-by: Jonathan Zhang <jonzhang@fb.com> Change-Id: I428b7de6462b47492d9526042018395d2f99cb2a Reviewed-on: https://review.coreboot.org/c/coreboot/+/44531 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
-rw-r--r--src/mainboard/facebook/watson/board.fmd8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/facebook/watson/board.fmd b/src/mainboard/facebook/watson/board.fmd
index e2b8f58d063b..6c58d12ebdbf 100644
--- a/src/mainboard/facebook/watson/board.fmd
+++ b/src/mainboard/facebook/watson/board.fmd
@@ -9,8 +9,8 @@ FLASH@0xff000000 0x1000000 {
FMAP@0x0 0x1000
RW_MISC@0x1000 0xe000 {
RW_ELOG@0x0 0x4000
- RW_VPD@0x4000 0x2000
- RW_MISC_UNUSED@0x6000 0x5000
+ RW_VPD@0x4000 0x4000
+ RW_MISC_UNUSED@0x8000 0x4000
RW_NVRAM@0xc000 0x2000
}
UNIFIED_MRC_CACHE@0x10000 0x20000 {
@@ -19,7 +19,7 @@ FLASH@0xff000000 0x1000000 {
}
# This only exists to satisfy tools that specifically
# look for RO_VPD.
- RO_VPD@0x30000 0x1000
- COREBOOT(CBFS)@0x31000 0x9cf000
+ RO_VPD@0x30000 0x4000
+ COREBOOT(CBFS)@0x34000
}
}