diff options
| author | Nico Huber <nico.h@gmx.de> | 2019-11-16 23:57:18 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-11-18 11:48:49 +0000 |
| commit | 770e73d0a2d7842fb86d024930643eac48e22c69 (patch) | |
| tree | 523796917a258bfb5d8d12f899ea593c8dd8d6e3 | |
| parent | fa5d0f835b1f3bb8907e616913cbf7b91d09ef26 (diff) | |
| download | coreboot-770e73d0a2d7842fb86d024930643eac48e22c69.tar.gz coreboot-770e73d0a2d7842fb86d024930643eac48e22c69.tar.bz2 coreboot-770e73d0a2d7842fb86d024930643eac48e22c69.zip | |
mb/apple/macbookair4_2: Drop unnecessary PCH config
mainboard_pch_lpc_setup() and mainboard_late_rcba_config() did 4
things here on top of the generic PCH code:
1. Enabling LPC decoding for gameports. It seems unlikely
that anything is using these ports and there is no code
to support gameports.
2. Decoding of COM3 instead of COM2. What COM?
3. Premature locking of ETR3/global reset. Bad idea.
4. Disabling the GbE port in BUC. Already done by PCH code.
Change-Id: Ie92dbf5c6813435995c4d24ed807ffc8d125953a
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36886
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
| -rw-r--r-- | src/mainboard/apple/macbookair4_2/early_init.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/mainboard/apple/macbookair4_2/early_init.c b/src/mainboard/apple/macbookair4_2/early_init.c index bfd070ca1cac..860d9d46dd16 100644 --- a/src/mainboard/apple/macbookair4_2/early_init.c +++ b/src/mainboard/apple/macbookair4_2/early_init.c @@ -20,18 +20,6 @@ #include <southbridge/intel/bd82x6x/pch.h> #include <cbfs.h> -void mainboard_pch_lpc_setup(void) -{ - pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f); - pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0070); - pci_write_config32(PCI_DEV(0, 0x1f, 0), 0xac, 0x80000000); -} - -void mainboard_late_rcba_config(void) -{ - /* Disable devices. */ - RCBA32(0x3414) = 0x00000020; -} const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 0, -1 }, { 1, 0, -1 }, |