summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Roth <martin@coreboot.org>2020-02-09 14:30:26 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-03-04 15:50:11 +0000
commite33ecb0e0842e6e8fbb51280f4495538623af606 (patch)
treecbb883e58cb6e9817a295042934c47a51c8bd8dc
parent98477da40527aca023e51e42f8d35fbdfae2829b (diff)
downloadcoreboot-e33ecb0e0842e6e8fbb51280f4495538623af606.tar.gz
coreboot-e33ecb0e0842e6e8fbb51280f4495538623af606.tar.bz2
coreboot-e33ecb0e0842e6e8fbb51280f4495538623af606.zip
Makefile.inc: Ignore _HID & _ADR conflicts in Broadwell & Lynxpoint
We haven't been able to update IASL in 8 months because of this conflict. Ignoring it doesn't make things any worse than they are now. Signed-off-by: Martin Roth <martin@coreboot.org> Change-Id: Iced2e55e9f2aa7a262a5c1ffeff32af78acfa35e Reviewed-on: https://review.coreboot.org/c/coreboot/+/38810 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> (cherry picked from commit 12e9c5ee86f9aa87b1e84bfc59e6cdbab5a4b254) Reviewed-on: https://review.coreboot.org/c/coreboot/+/38959 Reviewed-by: Patrick Georgi <pgeorgi@google.com>
-rw-r--r--Makefile.inc9
1 files changed, 9 insertions, 0 deletions
diff --git a/Makefile.inc b/Makefile.inc
index f26fead343e0..0b09472d3958 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -261,7 +261,16 @@ EMPTY_RESOURCE_TEMPLATE_WARNING = 3150
# Redundant offset remarks are not useful in any way and are masking useful
# ones that might indicate an issue so it is better to hide them.
REDUNDANT_OFFSET_REMARK = 2158
+# Ignore _HID & _ADR coexisting in Intel Lynxpoint and Broadwell ASL code.
+# See cb:38803 & cb:38802
+# "Multiple types (Device object requires either a _HID or _ADR, but not both)"
+MULTIPLE_TYPES_WARNING = 3073
+
+ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_LYNXPOINT)$(CONFIG_SOC_INTEL_BROADWELL),y)
+IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK) -vw $(MULTIPLE_TYPES_WARNING)
+else
IGNORED_IASL_WARNINGS = -vw $(EMPTY_RESOURCE_TEMPLATE_WARNING) -vw $(REDUNDANT_OFFSET_REMARK)
+endif
define asl_template
$(CONFIG_CBFS_PREFIX)/$(1).aml-file = $(obj)/$(1).aml