diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2021-11-05 10:29:24 -0600 |
|---|---|---|
| committer | Raul Rangel <rrangel@chromium.org> | 2021-11-08 19:58:46 +0000 |
| commit | 4911dc7ca90cfe758227e7a86b8c950a48c6ff6e (patch) | |
| tree | 979dec09ca43aaf4acd4b7274b2ce0ab7b98fbec | |
| parent | a3b290732dd1f06c5b16228c9a11529e1b43372e (diff) | |
| download | coreboot-4911dc7ca90cfe758227e7a86b8c950a48c6ff6e.tar.gz coreboot-4911dc7ca90cfe758227e7a86b8c950a48c6ff6e.tar.bz2 coreboot-4911dc7ca90cfe758227e7a86b8c950a48c6ff6e.zip | |
drivers/intel/fsp2_0: Allow FSP-M to be relocated
AMD platforms pass in the base address to cbfs tool:
fspm.bin-options: -b $(CONFIG_FSP_M_ADDR)
There is no technical reason not to allow FSP-M to be relocated when
!XIP. By allowing this, we no longer need to pass in the base address
into cbfstool when adding fspm.bin. This enables passing in the
`--alignment` argument to cbfs tool instead. cbfstool currently has a
check that prevents both `-b` and `-a` from being passed in.
BUG=b:179699789
TEST=Boot guybrush to OS
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: I797fb319333c53ad0bbf7340924f7d07dfc7de30
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58984
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
| -rw-r--r-- | src/commonlib/Makefile.inc | 3 | ||||
| -rw-r--r-- | src/drivers/intel/fsp2_0/util.c | 4 |
2 files changed, 5 insertions, 2 deletions
diff --git a/src/commonlib/Makefile.inc b/src/commonlib/Makefile.inc index 53975bcad8c4..9347f88f9c0d 100644 --- a/src/commonlib/Makefile.inc +++ b/src/commonlib/Makefile.inc @@ -22,6 +22,9 @@ smm-y += region.c postcar-y += region.c ramstage-$(CONFIG_PLATFORM_USES_FSP1_1) += fsp_relocate.c +ifeq ($(CONFIG_FSP_M_XIP),) +romstage-$(CONFIG_PLATFORM_USES_FSP2_0) += fsp_relocate.c +endif ramstage-$(CONFIG_PLATFORM_USES_FSP2_0) += fsp_relocate.c bootblock-y += cbfs.c diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index 112801333f99..49934fe6de0f 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -163,8 +163,8 @@ enum cb_err fsp_load_component(struct fsp_load_descriptor *fspld, struct fsp_hea if (!dest) return CB_ERR; - /* Don't allow FSP-M relocation. */ - if (!fspm_env() && fsp_component_relocate((uintptr_t)dest, dest, output_size) < 0) { + /* Don't allow FSP-M relocation when XIP. */ + if (!fspm_xip() && fsp_component_relocate((uintptr_t)dest, dest, output_size) < 0) { printk(BIOS_ERR, "Unable to relocate FSP component!\n"); return CB_ERR; } |