diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2021-11-04 04:44:54 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-11-05 16:24:59 +0000 |
| commit | 996808e52a19354de37cc29f8bb50296aa543c99 (patch) | |
| tree | 6fecaf258954331cffd25b0e2e85cc207fc890d2 | |
| parent | be7692a20cf323bb257de480957bba12428a973a (diff) | |
| download | coreboot-996808e52a19354de37cc29f8bb50296aa543c99.tar.gz coreboot-996808e52a19354de37cc29f8bb50296aa543c99.tar.bz2 coreboot-996808e52a19354de37cc29f8bb50296aa543c99.zip | |
soc/amd/*/include/smi: fix off-by-one in SCIMAPS defines
SCIMAPS is the total number of SCI to GEVENT mappings. configure_scimap
returns early when the scimap is greater or equal than SCIMAPS, so for
SMITYPE_ACDC_TIMER it returned early without doing what was expected
from it to do despite that being a valid value, so fix this off-by-one.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ibaf8c5618ddbf0b8d4cd612a7f1347d8562bbfcb
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58952
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
| -rw-r--r-- | src/soc/amd/cezanne/include/soc/smi.h | 2 | ||||
| -rw-r--r-- | src/soc/amd/picasso/include/soc/smi.h | 2 | ||||
| -rw-r--r-- | src/soc/amd/stoneyridge/include/soc/smi.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/soc/amd/cezanne/include/soc/smi.h b/src/soc/amd/cezanne/include/soc/smi.h index dc299a5a95a4..f0948bbbc7e8 100644 --- a/src/soc/amd/cezanne/include/soc/smi.h +++ b/src/soc/amd/cezanne/include/soc/smi.h @@ -6,7 +6,7 @@ #include <types.h> #define SMI_GEVENTS 24 -#define SCIMAPS 58 +#define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32 #define SMI_EVENT_STATUS 0x0 diff --git a/src/soc/amd/picasso/include/soc/smi.h b/src/soc/amd/picasso/include/soc/smi.h index e86809eb2ac4..8256b2116a9e 100644 --- a/src/soc/amd/picasso/include/soc/smi.h +++ b/src/soc/amd/picasso/include/soc/smi.h @@ -6,7 +6,7 @@ #include <types.h> #define SMI_GEVENTS 24 -#define SCIMAPS 58 +#define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32 #define SMI_EVENT_STATUS 0x0 diff --git a/src/soc/amd/stoneyridge/include/soc/smi.h b/src/soc/amd/stoneyridge/include/soc/smi.h index 61624755c5b4..0e0bc3715ae3 100644 --- a/src/soc/amd/stoneyridge/include/soc/smi.h +++ b/src/soc/amd/stoneyridge/include/soc/smi.h @@ -4,7 +4,7 @@ #define AMD_STONEYRIDGE_SMI_H #define SMI_GEVENTS 24 -#define SCIMAPS 58 +#define SCIMAPS 59 /* 0..58 */ #define SCI_GPES 32 #define SMI_EVENT_STATUS 0x0 |