diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-11-03 16:42:48 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2021-11-05 15:31:26 +0000 |
| commit | d16d00b71ae8f1bd679272753144002ada4f63f6 (patch) | |
| tree | 7b303f38cc52dc22615726ba466c6c661cbcb05f | |
| parent | 04c497a6ba6ba0219da5c4a32570fa46a0b239b9 (diff) | |
| download | coreboot-d16d00b71ae8f1bd679272753144002ada4f63f6.tar.gz coreboot-d16d00b71ae8f1bd679272753144002ada4f63f6.tar.bz2 coreboot-d16d00b71ae8f1bd679272753144002ada4f63f6.zip | |
mb/emulation/qemu-i440fx: Refactor `fw_cfg_max_cpus()`
Return 0 instead of -1 in case of error. Both values indicate an error
has happened. Adapt `cpu_bus_scan()` accordingly.
Change-Id: I0f83fdc41c20ed3aae80829432fc84024f5b9b47
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58918
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
| -rw-r--r-- | src/mainboard/emulation/qemu-i440fx/fw_cfg.c | 2 | ||||
| -rw-r--r-- | src/mainboard/emulation/qemu-i440fx/northbridge.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index 01be2c3cea8b..3206e4cec797 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -133,7 +133,7 @@ int fw_cfg_max_cpus(void) unsigned short max_cpus; if (!fw_cfg_present()) - return -1; + return 0; fw_cfg_get(FW_CFG_MAX_CPUS, &max_cpus, sizeof(max_cpus)); return max_cpus; diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index d041b0c6736f..9785a3acac1a 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -265,11 +265,11 @@ static void cpu_bus_init(struct device *dev) static void cpu_bus_scan(struct device *bus) { - int max_cpus = fw_cfg_max_cpus(); + unsigned int max_cpus = fw_cfg_max_cpus(); struct device *cpu; int i; - if (max_cpus < 0) + if (max_cpus == 0) return; /* * Do not install more CPUs than supported by coreboot. |