summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWerner Zeh <werner.zeh@siemens.com>2022-02-21 07:52:13 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-02-22 15:25:00 +0000
commit6f74d38dc8d2efab31259b2f280af9484b6d3585 (patch)
treed77054969346db47c244af75a2c379fefc52f3ae
parent88ccd4863c9c893edd0aa6d119c357b3301c5285 (diff)
downloadcoreboot-6f74d38dc8d2efab31259b2f280af9484b6d3585.tar.gz
coreboot-6f74d38dc8d2efab31259b2f280af9484b6d3585.tar.bz2
coreboot-6f74d38dc8d2efab31259b2f280af9484b6d3585.zip
mb/siemens/mc_apl2: Enable PCI device for I2C bus 0
On mc_apl2 the external RTC is connected to I2C bus 3. All other I2C bus devices (16.0, 16.1 and 16.2) have been disabled as they are not used. While coreboot can handle the case where a PCI device does not have function 0 enabled but a later one (here function 3), Linux seems to check for function 0 first and ignores the rest if function 0 is missing. So enable PCI device 16.0 in order to let Linux use 16.3 again. Test=Boot into Linux and make sure that PCI device 16.0 and 16.3 are visible and I2C attached RTC works properly. Change-Id: I55a748b6de8128f4b26b908118feff9f06d3fb7c Signed-off-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62215 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
-rw-r--r--src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb
index 74402566cf64..6c17d6329870 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/devicetree.cb
@@ -99,7 +99,7 @@ chip soc/intel/apollolake
end
device pci 15.0 on end # - XHCI
device pci 15.1 off end # - XDCI
- device pci 16.0 off end # - I2C 0
+ device pci 16.0 on end # - I2C 0
device pci 16.1 off end # - I2C 1
device pci 16.2 off end # - I2C 2
device pci 16.3 on # - I2C 3