diff options
| author | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2022-10-10 13:55:58 -0500 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-10-14 16:10:23 +0000 |
| commit | 5e2f1b1e646da2e2333252f1f798dff419df0309 (patch) | |
| tree | e58380c4e1278e89a3d6f6b80405200fffb0460f | |
| parent | fec16a3574921743246bafe617659c4d73b8011f (diff) | |
| download | coreboot-5e2f1b1e646da2e2333252f1f798dff419df0309.tar.gz coreboot-5e2f1b1e646da2e2333252f1f798dff419df0309.tar.bz2 coreboot-5e2f1b1e646da2e2333252f1f798dff419df0309.zip | |
ec/google/chromeec: Demote LPC EC error printk from ERR to SPEW
Several EC host commands check for support of a given feature or msg
version, and a non-zero response does not necessarily indicate an actual
error. Since the caller is (should be) handling the non-zero response to
the host command, demote the EC printk from ERR to SPEW to clean up the
console log and prevent non-errors from causing false failures in
firmware tests.
BUG=b:238961053
Change-Id: Ib7afc0b7e5b571acb56252f7adb518a6b2716b62
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68259
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/ec/google/chromeec/ec_lpc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index a82ea5d9abf5..080b95da445e 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -239,7 +239,7 @@ static int google_chromeec_command_v3(struct chromeec_command *cec_command) /* Check result */ cec_command->cmd_code = read_byte(EC_LPC_ADDR_HOST_DATA); if (cec_command->cmd_code) { - printk(BIOS_ERR, "EC returned error result code %d\n", + printk(BIOS_SPEW, "EC returned error result code %d\n", cec_command->cmd_code); return -i; } |