summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMario Scheithauer <mario.scheithauer@siemens.com>2022-01-26 11:49:10 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-02-01 11:54:59 +0000
commitb11f381740448c10908419ada0d405b05dc37dc0 (patch)
tree76c64408501a574f041721a2d981bb8e98bbec09
parent87d1cc659888b7a026ca42be83cd91d2a2d876d2 (diff)
downloadcoreboot-b11f381740448c10908419ada0d405b05dc37dc0.tar.gz
coreboot-b11f381740448c10908419ada0d405b05dc37dc0.tar.bz2
coreboot-b11f381740448c10908419ada0d405b05dc37dc0.zip
soc/intel/appololake: Allow to configure SATA ALPM via devicetree
Add a devicetree option to disable SATA Aggressive Link Power Management. ALPM is a method of saving power. The corresponding FSP-S UPD parameter is enabled by default. It may be that this feature is unwanted, for example for a real-time system. Therefore, allow to disable ALPM using the devicetree. Change-Id: Ica8920a87ebebe83f5d8cb4d6c8c0a6105e183e4 Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/61401 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
-rw-r--r--src/soc/intel/apollolake/chip.c4
-rw-r--r--src/soc/intel/apollolake/chip.h3
2 files changed, 7 insertions, 0 deletions
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 98844a52fdde..82ec2da4536d 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -693,6 +693,10 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *silupd)
silconfig->PavpEnable = CONFIG(PAVP);
+ /* SATA config */
+ if (is_devfn_enabled(PCH_DEVFN_SATA))
+ silconfig->SataSalpSupport = !(cfg->DisableSataSalpSupport);
+
mainboard_silicon_init_params(silconfig);
}
diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h
index 482b33330620..f531381fac46 100644
--- a/src/soc/intel/apollolake/chip.h
+++ b/src/soc/intel/apollolake/chip.h
@@ -190,6 +190,9 @@ struct soc_intel_apollolake_config {
* 0:Enable (default), 1:Disable.
*/
uint8_t disable_xhci_lfps_pm;
+
+ /* SATA Aggressive Link Power Management */
+ uint8_t DisableSataSalpSupport;
};
typedef struct soc_intel_apollolake_config config_t;