diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2022-10-17 15:47:11 -0500 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-10-21 14:31:35 +0000 |
| commit | dba310c5546c833cf4bbbfa0102ae3848ec370e2 (patch) | |
| tree | 4ccfdc155c58b34bf2ba78aca88e92ecac4e6375 | |
| parent | c4c0f00a57af8bd1224a6d5b72084acc44e90250 (diff) | |
| download | coreboot-dba310c5546c833cf4bbbfa0102ae3848ec370e2.tar.gz coreboot-dba310c5546c833cf4bbbfa0102ae3848ec370e2.tar.bz2 coreboot-dba310c5546c833cf4bbbfa0102ae3848ec370e2.zip | |
soc/intel/apollolake: Skip SMI lockdown on Apollolake
Commit d9ef02ce (soc/intel/apollolake: Lock down Global SMI) breaks
SMM/SMI on Apollolake (but not Geminilake), so guard it accordingly.
TEST=build/boot google/reef, verify SMM/SMI/SMMSTORE functional.
Change-Id: I00cbe046b61e6c342f7961670478d0ca8d365c2e
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68599
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
| -rw-r--r-- | src/soc/intel/apollolake/lockdown.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/soc/intel/apollolake/lockdown.c b/src/soc/intel/apollolake/lockdown.c index e11778b5dce4..5de4bdd2c13b 100644 --- a/src/soc/intel/apollolake/lockdown.c +++ b/src/soc/intel/apollolake/lockdown.c @@ -18,5 +18,6 @@ static void pmc_lock_smi(void) void soc_lockdown_config(int chipset_lockdown) { /* APL only supports CHIPSET_LOCKDOWN_COREBOOT */ - pmc_lock_smi(); + if (CONFIG(SOC_INTEL_GEMINILAKE)) + pmc_lock_smi(); } |