summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2022-10-13 15:16:45 +0200
committerFelix Held <felix-coreboot@felixheld.de>2022-10-14 15:38:30 +0000
commite109a6a47f2c1e3fc6ad162645d3654d190ea455 (patch)
tree9836ce7a0d33e2ea35b7b39eadef7c0ffcfe44b5
parent2595946bcd40ef9dd7526eb48c19ca6c90786c2e (diff)
downloadcoreboot-e109a6a47f2c1e3fc6ad162645d3654d190ea455.tar.gz
coreboot-e109a6a47f2c1e3fc6ad162645d3654d190ea455.tar.bz2
coreboot-e109a6a47f2c1e3fc6ad162645d3654d190ea455.zip
mb/amd/padmelon/bootblock/OemCustomize: add TODO for Prairie Falcon
The PCIe port descriptor list seems to be specific to Merlin Falcon and Prairie Falcon has a different PCIe root port configuration. Since I neither have the board nor the different APUs, I just add a comment about this instead of trying to come up with a PCIe port descriptor list that may or may not work properly on Prairie Falcon APUs. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I8e1eb67a8f684297bbefc6e2593250d7bd45593f Reviewed-on: https://review.coreboot.org/c/coreboot/+/68407 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
-rw-r--r--src/mainboard/amd/padmelon/bootblock/OemCustomize.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/mainboard/amd/padmelon/bootblock/OemCustomize.c b/src/mainboard/amd/padmelon/bootblock/OemCustomize.c
index 69374299341f..1f4bd3cb3900 100644
--- a/src/mainboard/amd/padmelon/bootblock/OemCustomize.c
+++ b/src/mainboard/amd/padmelon/bootblock/OemCustomize.c
@@ -2,6 +2,12 @@
#include <amdblocks/agesawrapper.h>
+/*
+ * TODO:
+ * Check if a separate PCIe port list is needed for Prairie Falcon APUs. Only Merlin Falcon has
+ * PCIe root ports on the functions of bus 0 device 3.
+ */
+
static const PCIe_PORT_DESCRIPTOR PortList[] = {
/*
* Init Port descriptor (PCIe port, Lanes 8-15,