summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2023-05-02 12:53:00 +0300
committerShelley Chen <shchen@google.com>2023-05-10 21:27:29 +0000
commit85556ac1dc9472a7624cdc3c82aa890407ecceda (patch)
treebc6fd0b8ebfe83e1337e8f568e65b0989f9b610b
parent5cd548b77308c86b474ffd2a16e9a89bc4efa7ec (diff)
downloadcoreboot-85556ac1dc9472a7624cdc3c82aa890407ecceda.tar.gz
coreboot-85556ac1dc9472a7624cdc3c82aa890407ecceda.tar.bz2
coreboot-85556ac1dc9472a7624cdc3c82aa890407ecceda.zip
soc/intel: Clean up some includes
Change-Id: Ibb680bb8f94fb8a2812f420ac38f15684b5c0b4f Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74978 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
-rw-r--r--src/soc/intel/baytrail/fadt.c1
-rw-r--r--src/soc/intel/baytrail/pmutil.c4
-rw-r--r--src/soc/intel/braswell/fadt.c1
-rw-r--r--src/soc/intel/braswell/pmutil.c2
-rw-r--r--src/soc/intel/braswell/smihandler.c2
-rw-r--r--src/soc/intel/broadwell/pch/fadt.c1
-rw-r--r--src/soc/intel/broadwell/pch/pmutil.c6
-rw-r--r--src/soc/intel/broadwell/pch/smihandler.c12
8 files changed, 13 insertions, 16 deletions
diff --git a/src/soc/intel/baytrail/fadt.c b/src/soc/intel/baytrail/fadt.c
index de89ef1ae01f..e4e225e42e36 100644
--- a/src/soc/intel/baytrail/fadt.c
+++ b/src/soc/intel/baytrail/fadt.c
@@ -3,7 +3,6 @@
#include <acpi/acpi.h>
#include <soc/iomap.h>
#include <soc/pm.h>
-#include "chip.h"
void acpi_fill_fadt(acpi_fadt_t *fadt)
{
diff --git a/src/soc/intel/baytrail/pmutil.c b/src/soc/intel/baytrail/pmutil.c
index 79f95bbf0380..6308227a8cf6 100644
--- a/src/soc/intel/baytrail/pmutil.c
+++ b/src/soc/intel/baytrail/pmutil.c
@@ -7,18 +7,18 @@
#include <acpi/acpi_pm.h>
#include <arch/io.h>
#include <bootmode.h>
+#include <console/console.h>
#include <device/device.h>
#include <device/mmio.h>
#include <device/pci.h>
#include <device/pci_ops.h>
-#include <console/console.h>
#include <halt.h>
+#include <security/vboot/vbnv.h>
#include <soc/iomap.h>
#include <soc/lpc.h>
#include <soc/pci_devs.h>
#include <soc/pm.h>
-#include <security/vboot/vbnv.h>
uint16_t get_pmbase(void)
{
diff --git a/src/soc/intel/braswell/fadt.c b/src/soc/intel/braswell/fadt.c
index d057d217ae2b..ac1653d33992 100644
--- a/src/soc/intel/braswell/fadt.c
+++ b/src/soc/intel/braswell/fadt.c
@@ -4,7 +4,6 @@
#include <soc/acpi.h>
#include <soc/iomap.h>
#include <soc/pm.h>
-#include "chip.h"
void acpi_fill_fadt(acpi_fadt_t *fadt)
{
diff --git a/src/soc/intel/braswell/pmutil.c b/src/soc/intel/braswell/pmutil.c
index 3efcc7b6defa..ea7f0caf2eb0 100644
--- a/src/soc/intel/braswell/pmutil.c
+++ b/src/soc/intel/braswell/pmutil.c
@@ -6,12 +6,12 @@
#include <arch/io.h>
#include <assert.h>
#include <bootmode.h>
+#include <console/console.h>
#include <device/device.h>
#include <device/mmio.h>
#include <device/pci.h>
#include <device/pci_ops.h>
#include <halt.h>
-#include <console/console.h>
#include <soc/iomap.h>
#include <soc/lpc.h>
#include <soc/pci_devs.h>
diff --git a/src/soc/intel/braswell/smihandler.c b/src/soc/intel/braswell/smihandler.c
index 44a66123d8ea..f2151a9bb316 100644
--- a/src/soc/intel/braswell/smihandler.c
+++ b/src/soc/intel/braswell/smihandler.c
@@ -11,12 +11,12 @@
#include <device/pci_def.h>
#include <elog.h>
#include <gpio.h>
+#include <smmstore.h>
#include <soc/nvs.h>
#include <soc/pci_devs.h>
#include <soc/pm.h>
#include <spi-generic.h>
#include <stdint.h>
-#include <smmstore.h>
void southbridge_smi_set_eos(void)
{
diff --git a/src/soc/intel/broadwell/pch/fadt.c b/src/soc/intel/broadwell/pch/fadt.c
index 8b79ec9c5894..4e74d58e47ee 100644
--- a/src/soc/intel/broadwell/pch/fadt.c
+++ b/src/soc/intel/broadwell/pch/fadt.c
@@ -3,7 +3,6 @@
#include <acpi/acpi.h>
#include <soc/iomap.h>
#include <soc/pm.h>
-#include "chip.h"
void acpi_fill_fadt(acpi_fadt_t *fadt)
{
diff --git a/src/soc/intel/broadwell/pch/pmutil.c b/src/soc/intel/broadwell/pch/pmutil.c
index e310416eaac0..8fc16700378e 100644
--- a/src/soc/intel/broadwell/pch/pmutil.c
+++ b/src/soc/intel/broadwell/pch/pmutil.c
@@ -8,16 +8,16 @@
#include <acpi/acpi.h>
#include <arch/io.h>
#include <bootmode.h>
-#include <device/pci_ops.h>
+#include <console/console.h>
#include <device/device.h>
+#include <device/pci_ops.h>
#include <device/pci.h>
#include <halt.h>
-#include <console/console.h>
+#include <security/vboot/vbnv.h>
#include <soc/iomap.h>
#include <soc/lpc.h>
#include <soc/pci_devs.h>
#include <soc/pm.h>
-#include <security/vboot/vbnv.h>
#include <stdint.h>
#define GPIO_ALT_GPI_SMI_STS 0x50
diff --git a/src/soc/intel/broadwell/pch/smihandler.c b/src/soc/intel/broadwell/pch/smihandler.c
index 14d08af7af86..99906d944cd9 100644
--- a/src/soc/intel/broadwell/pch/smihandler.c
+++ b/src/soc/intel/broadwell/pch/smihandler.c
@@ -3,25 +3,25 @@
#include <delay.h>
#include <types.h>
#include <arch/io.h>
-#include <device/mmio.h>
-#include <device/pci_ops.h>
#include <console/console.h>
+#include <cpu/intel/em64t101_save_state.h>
#include <cpu/x86/cache.h>
-#include <device/pci_def.h>
#include <cpu/x86/smm.h>
-#include <cpu/intel/em64t101_save_state.h>
+#include <device/mmio.h>
+#include <device/pci_def.h>
+#include <device/pci_ops.h>
+#include <drivers/intel/gma/i915_reg.h>
#include <spi-generic.h>
#include <elog.h>
#include <halt.h>
#include <option.h>
+#include <smmstore.h>
#include <soc/lpc.h>
#include <soc/nvs.h>
#include <soc/pci_devs.h>
#include <soc/pm.h>
#include <soc/rcba.h>
#include <soc/xhci.h>
-#include <drivers/intel/gma/i915_reg.h>
-#include <smmstore.h>
/**
* @brief Set the EOS bit