summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2023-11-12 07:03:23 +0000
committerMartin L Roth <gaumless@gmail.com>2023-11-17 22:18:21 +0000
commita2dffba45f2c957e9cf069af59d99751a9e96b0e (patch)
treecc172f622d912a4f88d446719a4c7c42597455af
parente0a1ca5ac967977749e68ebe3710ef427079f2f9 (diff)
downloadcoreboot-a2dffba45f2c957e9cf069af59d99751a9e96b0e.tar.gz
coreboot-a2dffba45f2c957e9cf069af59d99751a9e96b0e.tar.bz2
coreboot-a2dffba45f2c957e9cf069af59d99751a9e96b0e.zip
mb/google/herobrine: Move selects from Kconfig.name to Kconfig
Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I25b7adccf60abe515d129f8d00383165eccf6431 Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79028 Reviewed-by: Martin L Roth <gaumless@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/herobrine/Kconfig27
-rw-r--r--src/mainboard/google/herobrine/Kconfig.name9
2 files changed, 27 insertions, 9 deletions
diff --git a/src/mainboard/google/herobrine/Kconfig b/src/mainboard/google/herobrine/Kconfig
index a95ac068b23b..45f296cb2846 100644
--- a/src/mainboard/google/herobrine/Kconfig
+++ b/src/mainboard/google/herobrine/Kconfig
@@ -1,6 +1,33 @@
config BOARD_GOOGLE_HEROBRINE_COMMON # Umbrella option to be selected by variants
def_bool n
+config BOARD_GOOGLE_HEROBRINE
+ select BOARD_GOOGLE_HEROBRINE_COMMON
+
+config BOARD_GOOGLE_HEROBRINE_REV0
+ select BOARD_GOOGLE_HEROBRINE_COMMON
+
+config BOARD_GOOGLE_SENOR
+ select BOARD_GOOGLE_HEROBRINE_COMMON
+
+config BOARD_GOOGLE_PIGLIN
+ select BOARD_GOOGLE_HEROBRINE_COMMON
+
+config BOARD_GOOGLE_HOGLIN
+ select BOARD_GOOGLE_HEROBRINE_COMMON
+
+config BOARD_GOOGLE_VILLAGER
+ select BOARD_GOOGLE_HEROBRINE_COMMON
+
+config BOARD_GOOGLE_EVOKER
+ select BOARD_GOOGLE_HEROBRINE_COMMON
+
+config BOARD_GOOGLE_ZOGLIN
+ select BOARD_GOOGLE_HEROBRINE_COMMON
+
+config BOARD_GOOGLE_ZOMBIE
+ select BOARD_GOOGLE_HEROBRINE_COMMON
+
if BOARD_GOOGLE_HEROBRINE_COMMON
config HEROBRINE_HAS_FINGERPRINT
diff --git a/src/mainboard/google/herobrine/Kconfig.name b/src/mainboard/google/herobrine/Kconfig.name
index e779c91bbc68..4c4937338b54 100644
--- a/src/mainboard/google/herobrine/Kconfig.name
+++ b/src/mainboard/google/herobrine/Kconfig.name
@@ -2,36 +2,27 @@ comment "Herobrine"
config BOARD_GOOGLE_HEROBRINE
bool "-> Herobrine"
- select BOARD_GOOGLE_HEROBRINE_COMMON
config BOARD_GOOGLE_HEROBRINE_REV0
bool "-> Herobrine_Rev0"
- select BOARD_GOOGLE_HEROBRINE_COMMON
config BOARD_GOOGLE_SENOR
bool "-> Senor"
- select BOARD_GOOGLE_HEROBRINE_COMMON
config BOARD_GOOGLE_PIGLIN
bool "-> Piglin"
- select BOARD_GOOGLE_HEROBRINE_COMMON
config BOARD_GOOGLE_HOGLIN
bool "-> Hoglin"
- select BOARD_GOOGLE_HEROBRINE_COMMON
config BOARD_GOOGLE_VILLAGER
bool "-> Villager"
- select BOARD_GOOGLE_HEROBRINE_COMMON
config BOARD_GOOGLE_EVOKER
bool "-> Evoker"
- select BOARD_GOOGLE_HEROBRINE_COMMON
config BOARD_GOOGLE_ZOGLIN
bool "-> Zoglin"
- select BOARD_GOOGLE_HEROBRINE_COMMON
config BOARD_GOOGLE_ZOMBIE
bool "-> Zombie"
- select BOARD_GOOGLE_HEROBRINE_COMMON