diff options
author | Elyes Haouas <ehaouas@noos.fr> | 2024-05-06 10:08:51 +0200 |
---|---|---|
committer | Elyes Haouas <ehaouas@noos.fr> | 2024-05-07 10:53:18 +0000 |
commit | 0f45e17f564a657ddf9804124e4e30da0edb1d13 (patch) | |
tree | 94482f30d5d59c8b2d8bf4af1feefe9b734d100f | |
parent | 239347a90934deb77443869b6544c31f9b261733 (diff) | |
download | coreboot-0f45e17f564a657ddf9804124e4e30da0edb1d13.tar.gz coreboot-0f45e17f564a657ddf9804124e4e30da0edb1d13.tar.bz2 coreboot-0f45e17f564a657ddf9804124e4e30da0edb1d13.zip |
dram/ddr5: Use the same naming convention as DDR{2,3,4}
Change-Id: I2cc38926b56315d4a828311917ff58051b34b777
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82214
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r-- | src/device/dram/spd.c | 16 | ||||
-rw-r--r-- | src/include/device/dram/ddr5.h | 28 | ||||
-rw-r--r-- | tests/lib/dimm_info_util-test.c | 6 |
3 files changed, 25 insertions, 25 deletions
diff --git a/src/device/dram/spd.c b/src/device/dram/spd.c index e33a26ad6831..41ec7c52c76f 100644 --- a/src/device/dram/spd.c +++ b/src/device/dram/spd.c @@ -135,26 +135,26 @@ static void convert_ddr4_module_type_to_spd_info(enum spd_dimm_type_ddr4 module_ } } -static void convert_ddr5_module_type_to_spd_info(enum ddr5_module_type module_type, +static void convert_ddr5_module_type_to_spd_info(enum spd_dimm_type_ddr5 module_type, struct spd_info *info) { switch (module_type) { - case DDR5_SPD_RDIMM: - case DDR5_SPD_MINI_RDIMM: + case SPD_DDR5_DIMM_TYPE_RDIMM: + case SPD_DDR5_DIMM_TYPE_MINI_RDIMM: info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_REGISTERED; break; - case DDR5_SPD_UDIMM: - case DDR5_SPD_MINI_UDIMM: + case SPD_DDR5_DIMM_TYPE_UDIMM: + case SPD_DDR5_DIMM_TYPE_MINI_UDIMM: info->form_factor = MEMORY_FORMFACTOR_DIMM; info->type_detail = MEMORY_TYPE_DETAIL_UNBUFFERED; break; - case DDR5_SPD_SODIMM: - case DDR5_SPD_72B_SO_UDIMM: + case SPD_DDR5_DIMM_TYPE_SODIMM: + case SPD_DDR5_DIMM_TYPE_72B_SO_UDIMM: info->form_factor = MEMORY_FORMFACTOR_SODIMM; info->type_detail = MEMORY_TYPE_DETAIL_UNKNOWN; break; - case DDR5_SPD_2DPC: + case SPD_DDR5_DIMM_TYPE_2DPC: info->form_factor = MEMORY_FORMFACTOR_PROPRIETARY_CARD; info->type_detail = MEMORY_TYPE_DETAIL_UNKNOWN; break; diff --git a/src/include/device/dram/ddr5.h b/src/include/device/dram/ddr5.h index 37182da365c3..78d18b24f8ab 100644 --- a/src/include/device/dram/ddr5.h +++ b/src/include/device/dram/ddr5.h @@ -15,20 +15,20 @@ /** Maximum SPD size supported */ #define SPD_SIZE_MAX_DDR5 1024 -enum ddr5_module_type { - DDR5_SPD_RDIMM = 0x01, - DDR5_SPD_UDIMM = 0x02, - DDR5_SPD_SODIMM = 0x03, - DDR5_SPD_LRDIMM = 0x04, - DDR5_SPD_MINI_RDIMM = 0x05, - DDR5_SPD_MINI_UDIMM = 0x06, - DDR5_SPD_72B_SO_UDIMM = 0x08, - DDR5_SPD_72B_SO_RDIMM = 0x09, - DDR5_SPD_SOLDERED_DOWN = 0x0b, - DDR5_SPD_16B_SO_DIMM = 0x0c, - DDR5_SPD_32B_SO_RDIMM = 0x0d, - DDR5_SPD_1DPC = 0x0e, - DDR5_SPD_2DPC = 0x0f, +enum spd_dimm_type_ddr5 { + SPD_DDR5_DIMM_TYPE_RDIMM = 0x01, + SPD_DDR5_DIMM_TYPE_UDIMM = 0x02, + SPD_DDR5_DIMM_TYPE_SODIMM = 0x03, + SPD_DDR5_DIMM_TYPE_LRDIMM = 0x04, + SPD_DDR5_DIMM_TYPE_MINI_RDIMM = 0x05, + SPD_DDR5_DIMM_TYPE_MINI_UDIMM = 0x06, + SPD_DDR5_DIMM_TYPE_72B_SO_UDIMM = 0x08, + SPD_DDR5_DIMM_TYPE_72B_SO_RDIMM = 0x09, + SPD_DDR5_DIMM_TYPE_SOLDERED_DOWN = 0x0b, + SPD_DDR5_DIMM_TYPE_16B_SO_DIMM = 0x0c, + SPD_DDR5_DIMM_TYPE_32B_SO_RDIMM = 0x0d, + SPD_DDR5_DIMM_TYPE_1DPC = 0x0e, + SPD_DDR5_DIMM_TYPE_2DPC = 0x0f, }; /** diff --git a/tests/lib/dimm_info_util-test.c b/tests/lib/dimm_info_util-test.c index 624924f9c7c4..8e33988682f5 100644 --- a/tests/lib/dimm_info_util-test.c +++ b/tests/lib/dimm_info_util-test.c @@ -165,9 +165,9 @@ static void test_smbios_form_factor_to_spd_mod_type(void **state) .expected_module_type = SPD_DDR4_DIMM_TYPE_SO_DIMM, }, {.memory_type = MEMORY_TYPE_DDR5, - .udimm_allowed = {DDR5_SPD_UDIMM, DDR5_SPD_MINI_UDIMM}, - .rdimm_allowed = {DDR5_SPD_RDIMM, DDR5_SPD_MINI_RDIMM}, - .expected_module_type = DDR5_SPD_SODIMM}, + .udimm_allowed = {SPD_DDR5_DIMM_TYPE_UDIMM, SPD_DDR5_DIMM_TYPE_MINI_UDIMM}, + .rdimm_allowed = {SPD_DDR5_DIMM_TYPE_RDIMM, SPD_DDR5_DIMM_TYPE_MINI_RDIMM}, + .expected_module_type = SPD_DDR5_DIMM_TYPE_SODIMM}, }; /* Test for DDRx DIMM Modules */ |