summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEricKY Cheng <ericky_cheng@compal.corp-partner.google.com>2022-09-22 18:08:38 +0800
committerFelix Held <felix-coreboot@felixheld.de>2022-09-26 14:19:06 +0000
commit849d57a8e6ef57f94cc88c3a3e262296fc340cd5 (patch)
tree49ecd37cba716e6a570defd0d4e389876843cc27
parenteb1725971a77f75a241591576b7dceb62da72002 (diff)
downloadcoreboot-849d57a8e6ef57f94cc88c3a3e262296fc340cd5.tar.gz
coreboot-849d57a8e6ef57f94cc88c3a3e262296fc340cd5.tar.bz2
coreboot-849d57a8e6ef57f94cc88c3a3e262296fc340cd5.zip
mb/google/skyrim/var/winterhold: Bug fix, modify GXTP7863 irq setting
Modify GXTP7863 generic.irq to generic.irq_gpio. BUG=b:245082617 TEST=emerge-skyrim coreboot Signed-off-by: EricKY Cheng <ericky_cheng@compal.corp-partner.google.com> Change-Id: Iaf6cc6010132d5b33b06909ceb1069115a911b48 Reviewed-on: https://review.coreboot.org/c/coreboot/+/67771 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org>
-rw-r--r--src/mainboard/google/skyrim/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/skyrim/variants/winterhold/overridetree.cb2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c
index ac36aa20918d..a0fd7d173b8e 100644
--- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c
+++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c
@@ -68,7 +68,7 @@ static const struct soc_amd_gpio base_gpio_table[] = {
PAD_NF(GPIO_32, LPC_RST_L, PULL_NONE),
/* GPIO_33 - GPIO_39: Not available */
/* SOC_TCHPAD_INT_ODL */
- PAD_SCI(GPIO_40, PULL_NONE, EDGE_LOW),
+ PAD_SCI(GPIO_40, PULL_NONE, LEVEL_LOW),
/* GPIO_41: Not available */
/* WWAN_RST_L */
PAD_GPO(GPIO_42, HIGH),
diff --git a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb
index 544f54fbdae7..900cd2352c1f 100644
--- a/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb
+++ b/src/mainboard/google/skyrim/variants/winterhold/overridetree.cb
@@ -77,7 +77,7 @@ chip soc/amd/mendocino
chip drivers/i2c/hid
register "generic.hid" = ""GXTP7863""
register "generic.desc" = ""Goodix Touchpad""
- register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_40)"
+ register "generic.irq_gpio" = "ACPI_GPIO_IRQ_LEVEL_LOW(GPIO_40)"
register "generic.wake" = "GEVENT_20"
register "generic.detect" = "1"
register "hid_desc_reg_offset" = "0x20"