summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTim Wawrzynczak <twawrzynczak@chromium.org>2022-06-27 11:39:34 -0600
committerFelix Held <felix-coreboot@felixheld.de>2022-06-29 15:08:40 +0000
commiteb3e0985b8448f4cfeb451fc57cd11da8a7700a8 (patch)
treeda6517f7304ade185492ddf574e75c1966c446ac
parent2f8f1b44021aeb8c38a2fb2d0880dd93a00526a7 (diff)
downloadcoreboot-eb3e0985b8448f4cfeb451fc57cd11da8a7700a8.tar.gz
coreboot-eb3e0985b8448f4cfeb451fc57cd11da8a7700a8.tar.bz2
coreboot-eb3e0985b8448f4cfeb451fc57cd11da8a7700a8.zip
soc/intel/jasperlake: Fix PMC read_resources callback
The `limit` field for the PMC fixed BAR was incorrectly set to the `base + size + 1`, where it should be `base + size - 1`, to correctly tell the allocator the limit. Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Change-Id: Icf51333f438ce2597c008b48305cf5816dacd3f5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65461 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/soc/intel/jasperlake/pmc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/jasperlake/pmc.c b/src/soc/intel/jasperlake/pmc.c
index b6a17f3db874..4a4834547cc3 100644
--- a/src/soc/intel/jasperlake/pmc.c
+++ b/src/soc/intel/jasperlake/pmc.c
@@ -76,7 +76,7 @@ static void soc_pmc_read_resources(struct device *dev)
res = new_resource(dev, 1);
res->base = (resource_t)ACPI_BASE_ADDRESS;
res->size = (resource_t)ACPI_BASE_SIZE;
- res->limit = res->base + res->size + 1;
+ res->limit = res->base + res->size - 1;
res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
}