diff options
| author | Xi Chen <xixi.chen@mediatek.com> | 2020-12-01 16:17:24 +0800 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-12-09 23:18:10 +0000 |
| commit | 63eb64be26bfa30f1cc18d75ec98d63b3e8b4f26 (patch) | |
| tree | 6618f03a74fa869d67797e63e569552979b343f1 /Makefile.inc | |
| parent | 5c08c31775cb7f705b58e8be59a482754fa40df7 (diff) | |
| download | coreboot-63eb64be26bfa30f1cc18d75ec98d63b3e8b4f26.tar.gz coreboot-63eb64be26bfa30f1cc18d75ec98d63b3e8b4f26.tar.bz2 coreboot-63eb64be26bfa30f1cc18d75ec98d63b3e8b4f26.zip | |
Makefile.inc: Fix empty output when processing C struct files in CBFS
When passing $(@) to eval command, $(@) is replaced by empty string,
Also, the $(@) in cbfs-files-processor-struct is a temporary file name,
so we should quote it by an extra '$' or use the arg ($1 or $2)
directly.
For example:
cbfs-files-processor-struct= \
$(eval $(2): $(1) $(obj)/build.h $(KCONFIG_AUTOHEADER); \
# ** $(@) is empty string instead of $(2) **
printf " CC+STRIP $(@) \n"; \
# ** $(1) contains the name of source file **
printf " CC+STRIP $(1) \n"; \
......)
Signed-off-by: Xi Chen <xixi.chen@mediatek.com>
Change-Id: Id6a66e25d7dfe8fe6410e517593ed22a438d2f82
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48201
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'Makefile.inc')
| -rw-r--r-- | Makefile.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Makefile.inc b/Makefile.inc index 8cba96be4f77..dee4a2e92d9d 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -333,7 +333,7 @@ endef # arg2: binary file cbfs-files-processor-struct= \ $(eval $(2): $(1) $(obj)/build.h $(KCONFIG_AUTOHEADER); \ - printf " CC+STRIP $(@)\n"; \ + printf " CC+STRIP $(1)\n"; \ $(CC_ramstage) -MMD $(CPPFLAGS_ramstage) $(CFLAGS_ramstage) $$(ramstage-c-ccopts) -include $(KCONFIG_AUTOHEADER) -MT $(2) -o $(2).tmp -c $(1) && \ $(OBJCOPY_ramstage) -O binary --set-section-flags .bss*=alloc,contents,load $(2).tmp $(2); \ rm -f $(2).tmp) \ |