summaryrefslogtreecommitdiffstats
path: root/device/device.c
diff options
context:
space:
mode:
authorCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2007-11-20 18:20:53 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2007-11-20 18:20:53 +0000
commitfe31d1970c9126dce4defe26768b0c2ccc1313d9 (patch)
treeb51373421e2f47c074d040b92165926fa0bb71b7 /device/device.c
parent3de758e98a5750b93b7c5359e29763b979c9bea7 (diff)
downloadcoreboot-fe31d1970c9126dce4defe26768b0c2ccc1313d9.tar.gz
coreboot-fe31d1970c9126dce4defe26768b0c2ccc1313d9.tar.bz2
coreboot-fe31d1970c9126dce4defe26768b0c2ccc1313d9.zip
Cleanup printk usage and documentation. Drop the second banner as it was
an artifact from the time when we needed stage2 phase 1 code to make printk work. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de> git-svn-id: svn://coreboot.org/repository/LinuxBIOSv3@512 f3766cd6-281f-0410-b1cd-43a5c92072e9
Diffstat (limited to 'device/device.c')
-rw-r--r--device/device.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/device/device.c b/device/device.c
index 80eac82f86fb..aa81802ded76 100644
--- a/device/device.c
+++ b/device/device.c
@@ -692,14 +692,14 @@ int reset_bus(struct bus *bus)
*
* Starting at the first device on the global device link list,
* walk the list and call the device's phase1() method to do very
- * early setup. phase1 should only be used for devices that CAN NOT use
- * printk(), or that are part of making printk() work.
+ * early setup.
*/
void dev_phase1(void)
{
struct device *dev;
post_code(0x31);
+ printk(BIOS_DEBUG, "Phase 1: Very early setup...\n");
for (dev = all_devices; dev; dev = dev->next) {
if (dev->ops && dev->ops->phase1_set_device_operations) {
dev->ops->phase1_set_device_operations(dev);
@@ -715,7 +715,7 @@ void dev_phase1(void)
*
* Starting at the first device on the global device link list,
* walk the list and call the device's phase2() method to do
- * early setup. You can use printk() in phase 2 methods.
+ * early setup.
*/
void dev_phase2(void)
{
@@ -729,7 +729,7 @@ void dev_phase2(void)
printk(BIOS_SPEW,
"Calling phase2 phase2_setup_scan_bus...");
dev->ops->phase2_setup_scan_bus(dev);
- printk(BIOS_SPEW, " DONE");
+ printk(BIOS_SPEW, " done");
}
printk(BIOS_SPEW, "\n");
}