diff options
| author | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2008-02-16 19:18:32 +0000 |
|---|---|---|
| committer | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2008-02-16 19:18:32 +0000 |
| commit | 9f07a529340fe07aabe6aa26bd2b0761e960b48f (patch) | |
| tree | 6d15c70bf4cc262bd93046d68f73ae5645d0c2d0 /lib | |
| parent | 24a06158ba528aee6a23b01799fc368753e035da (diff) | |
| download | coreboot-9f07a529340fe07aabe6aa26bd2b0761e960b48f.tar.gz coreboot-9f07a529340fe07aabe6aa26bd2b0761e960b48f.tar.bz2 coreboot-9f07a529340fe07aabe6aa26bd2b0761e960b48f.zip | |
On 16.02.2008 07:41, ron minnich wrote:
> Alix1c won't boot with the zero decompress code.
> I think the code is using the wrong address on decompress.
Indeed, r601 broke all targets, you were just lucky that qemu didn't
explode as well.
It's the seemingly easy patches which break booting. With your hint, I
found the bug. Myles made a small, but important mistake with the memset
for the "zeroes" decompression.
The memset zeroed the archive instead of the destination. No wonder it
did explode.
This patch fixes it and also reverts the emergency commit r604 because
that one is no longer necessary.
Ron tested on the Alix1c, boots fine, ethernet and IDE working.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: svn://coreboot.org/repository/coreboot-v3@605 f3766cd6-281f-0410-b1cd-43a5c92072e9
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/lar.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/lar.c b/lib/lar.c index 325a3e1517ca..7a497dc9891f 100644 --- a/lib/lar.c +++ b/lib/lar.c @@ -172,7 +172,7 @@ int process_file(const struct mem_file *archive, void *where) #endif /* zeroes */ if (archive->compression == 3) { - memset(archive->start, 0, archive->reallen); + memset(where, 0, archive->reallen); return 0; } printk(BIOS_INFO, "LAR: Compression algorithm #%i not supported!\n", archive->compression); |