src: Use 'include <string.h>' when appropriate

Drop 'include <string.h>' when it is not used and
add it when it is missing.
Also extra lines removed, or added just before local includes.

Change-Id: Iccac4dbaa2dd4144fc347af36ecfc9747da3de20
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31966
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>

30 files changed, 1 insertions, 31 deletions

diff --git a/src/drivers/aspeed/ast2050/ast2050.c b/src/drivers/aspeed/ast2050/ast2050.c
index b36c3b16bc35..035d5c6ef935 100644
--- a/src/drivers/aspeed/ast2050/ast2050.c
+++ b/src/drivers/aspeed/ast2050/ast2050.c
@@ -14,7 +14,6 @@
  */
 #include <delay.h>
 #include <stdlib.h>
-#include <string.h>
 #include <arch/io.h>
 #include <edid.h>
 
diff --git a/src/drivers/emulation/qemu/bochs.c b/src/drivers/emulation/qemu/bochs.c
index de3feac20e1f..2310c9e463ac 100644
--- a/src/drivers/emulation/qemu/bochs.c
+++ b/src/drivers/emulation/qemu/bochs.c
@@ -15,7 +15,6 @@
 #include <delay.h>
 #include <edid.h>
 #include <stdlib.h>
-#include <string.h>
 #include <arch/io.h>
 
 #include <boot/coreboot_tables.h>
diff --git a/src/drivers/emulation/qemu/cirrus.c b/src/drivers/emulation/qemu/cirrus.c
index d647c0cab1bf..04edef44aa3e 100644
--- a/src/drivers/emulation/qemu/cirrus.c
+++ b/src/drivers/emulation/qemu/cirrus.c
@@ -18,7 +18,6 @@
 #include <delay.h>
 #include <edid.h>
 #include <stdlib.h>
-#include <string.h>
 
 #include <boot/coreboot_tables.h>
 #include <console/console.h>
diff --git a/src/drivers/generic/adau7002/adau7002.c b/src/drivers/generic/adau7002/adau7002.c
index 6e0d5f7fb842..1aff4533965f 100644
--- a/src/drivers/generic/adau7002/adau7002.c
+++ b/src/drivers/generic/adau7002/adau7002.c
@@ -19,7 +19,6 @@
 #include <device/device.h>
 #include <device/path.h>
 #include <stdint.h>
-#include <string.h>
 #include "chip.h"
 
 #if CONFIG(HAVE_ACPI_TABLES)
diff --git a/src/drivers/generic/max98357a/max98357a.c b/src/drivers/generic/max98357a/max98357a.c
index 3c677109b068..1408dacca616 100644
--- a/src/drivers/generic/max98357a/max98357a.c
+++ b/src/drivers/generic/max98357a/max98357a.c
@@ -20,7 +20,6 @@
 #include <device/path.h>
 #include <gpio.h>
 #include <stdint.h>
-#include <string.h>
 #include "chip.h"
 
 #if CONFIG(HAVE_ACPI_TABLES)
diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c
index f20678c72dc3..67760a0d03b4 100644
--- a/src/drivers/i2c/at24rf08c/at24rf08c.c
+++ b/src/drivers/i2c/at24rf08c/at24rf08c.c
@@ -14,7 +14,6 @@
  */
 
 #include <types.h>
-#include <string.h>
 #include <device/device.h>
 #include <device/smbus.h>
 #include <smbios.h>
diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c
index 5399f75395b5..2a4d78760e21 100644
--- a/src/drivers/i2c/da7219/da7219.c
+++ b/src/drivers/i2c/da7219/da7219.c
@@ -21,7 +21,7 @@
 #include <device/device.h>
 #include <device/path.h>
 #include <stdint.h>
-#include <string.h>
+
 #include "chip.h"
 
 #if CONFIG(HAVE_ACPI_TABLES)
diff --git a/src/drivers/i2c/max98373/max98373.c b/src/drivers/i2c/max98373/max98373.c
index 0431c2e5917e..07e23a81f96b 100644
--- a/src/drivers/i2c/max98373/max98373.c
+++ b/src/drivers/i2c/max98373/max98373.c
@@ -21,7 +21,6 @@
 #include <device/device.h>
 #include <device/path.h>
 #include <stdint.h>
-#include <string.h>
 #include "chip.h"
 
 #define MAX98373_ACPI_NAME	"MAXI"
diff --git a/src/drivers/i2c/max98927/max98927.c b/src/drivers/i2c/max98927/max98927.c
index 68a167d4a34e..395b79b4be26 100644
--- a/src/drivers/i2c/max98927/max98927.c
+++ b/src/drivers/i2c/max98927/max98927.c
@@ -21,7 +21,6 @@
 #include <device/device.h>
 #include <device/path.h>
 #include <stdint.h>
-#include <string.h>
 #include "chip.h"
 
 #define MAX98927_ACPI_NAME	"MAXI"
diff --git a/src/drivers/i2c/nau8825/nau8825.c b/src/drivers/i2c/nau8825/nau8825.c
index a98054abd08f..60c73b147d44 100644
--- a/src/drivers/i2c/nau8825/nau8825.c
+++ b/src/drivers/i2c/nau8825/nau8825.c
@@ -21,7 +21,6 @@
 #include <device/device.h>
 #include <device/path.h>
 #include <stdint.h>
-#include <string.h>
 #include "chip.h"
 
 #if CONFIG(HAVE_ACPI_TABLES)
diff --git a/src/drivers/i2c/rt5663/rt5663.c b/src/drivers/i2c/rt5663/rt5663.c
index 1ce5993dad07..415ae713c91e 100644
--- a/src/drivers/i2c/rt5663/rt5663.c
+++ b/src/drivers/i2c/rt5663/rt5663.c
@@ -21,7 +21,6 @@
 #include <device/device.h>
 #include <device/path.h>
 #include <stdint.h>
-#include <string.h>
 #include "chip.h"
 
 #define RT5663_ACPI_NAME	"RT53"
diff --git a/src/drivers/i2c/tpm/chip.c b/src/drivers/i2c/tpm/chip.c
index 687ce050ed06..7e950321b326 100644
--- a/src/drivers/i2c/tpm/chip.c
+++ b/src/drivers/i2c/tpm/chip.c
@@ -20,7 +20,6 @@
 #include <device/device.h>
 #include <device/path.h>
 #include <stdint.h>
-#include <string.h>
 #include "tpm.h"
 #include "chip.h"
 
diff --git a/src/drivers/i2c/tpm/tis_atmel.c b/src/drivers/i2c/tpm/tis_atmel.c
index 4b2f55441dbb..4456567e4d11 100644
--- a/src/drivers/i2c/tpm/tis_atmel.c
+++ b/src/drivers/i2c/tpm/tis_atmel.c
@@ -14,7 +14,6 @@
 
 #include <arch/early_variables.h>
 #include <stdint.h>
-#include <string.h>
 #include <assert.h>
 #include <commonlib/endian.h>
 #include <console/console.h>
diff --git a/src/drivers/intel/fsp1_0/hob.c b/src/drivers/intel/fsp1_0/hob.c
index 05060d83b083..0244d1c82137 100644
--- a/src/drivers/intel/fsp1_0/hob.c
+++ b/src/drivers/intel/fsp1_0/hob.c
@@ -14,7 +14,6 @@
  */
 
 #include <types.h>
-#include <string.h>
 #include <console/console.h>
 #include "fsp_util.h"
 
diff --git a/src/drivers/intel/fsp2_0/notify.c b/src/drivers/intel/fsp2_0/notify.c
index a5c7ef07daa3..34d7e89c7be7 100644
--- a/src/drivers/intel/fsp2_0/notify.c
+++ b/src/drivers/intel/fsp2_0/notify.c
@@ -14,7 +14,6 @@
 #include <console/console.h>
 #include <cpu/x86/mtrr.h>
 #include <fsp/util.h>
-#include <string.h>
 #include <timestamp.h>
 
 static void fsp_notify(enum fsp_notify_phase phase)
diff --git a/src/drivers/intel/fsp2_0/temp_ram_exit.c b/src/drivers/intel/fsp2_0/temp_ram_exit.c
index 5532c43c02ad..ced3584fd05c 100644
--- a/src/drivers/intel/fsp2_0/temp_ram_exit.c
+++ b/src/drivers/intel/fsp2_0/temp_ram_exit.c
@@ -14,7 +14,6 @@
 #include <fsp/api.h>
 #include <fsp/util.h>
 #include <memrange.h>
-#include <string.h>
 #include <cbfs.h>
 
 void fsp_temp_ram_exit(void)
diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c
index 220f14117746..58134db2d3f4 100644
--- a/src/drivers/intel/gma/intel_ddi.c
+++ b/src/drivers/intel/gma/intel_ddi.c
@@ -26,7 +26,6 @@
  *
  */
 #include <types.h>
-#include <string.h>
 #include <stdlib.h>
 #include <device/device.h>
 #include <device/pci_def.h>
diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c
index 0cea0ba311ac..903c48062ade 100644
--- a/src/drivers/intel/mipi_camera/camera.c
+++ b/src/drivers/intel/mipi_camera/camera.c
@@ -20,7 +20,6 @@
 #include <device/i2c_simple.h>
 #include <device/device.h>
 #include <device/path.h>
-#include <string.h>
 #include "chip.h"
 
 static void camera_fill_ssdt(struct device *dev)
diff --git a/src/drivers/ipmi/ipmi_kcs.c b/src/drivers/ipmi/ipmi_kcs.c
index 5ed46fe9fcd6..8d106837f9d5 100644
--- a/src/drivers/ipmi/ipmi_kcs.c
+++ b/src/drivers/ipmi/ipmi_kcs.c
@@ -17,7 +17,6 @@
 #include <console/console.h>
 #include <device/device.h>
 #include <arch/io.h>
-#include <string.h>
 #include <delay.h>
 #include "ipmi_kcs.h"
 
diff --git a/src/drivers/net/atl1e.c b/src/drivers/net/atl1e.c
index d6e7a841b100..f6f04a1035b8 100644
--- a/src/drivers/net/atl1e.c
+++ b/src/drivers/net/atl1e.c
@@ -23,7 +23,6 @@
 #include <device/mmio.h>
 #include <device/device.h>
 #include <cbfs.h>
-#include <string.h>
 #include <console/console.h>
 #include <device/pci.h>
 #include <device/pci_ops.h>
diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c
index caba600a3a6a..6f8aca2446c8 100644
--- a/src/drivers/net/ne2k.c
+++ b/src/drivers/net/ne2k.c
@@ -35,7 +35,6 @@ SMC8416 PIO support added by Andrew Bettison (andrewb@zip.com.au) on 4/3/02
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>
 #include <stdlib.h>
-#include <string.h>
 #include <ip_checksum.h>
 
 #include "ns8390.h"
diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.c b/src/drivers/siemens/nc_fpga/nc_fpga.c
index 831ac7954f32..ef1f2f213640 100644
--- a/src/drivers/siemens/nc_fpga/nc_fpga.c
+++ b/src/drivers/siemens/nc_fpga/nc_fpga.c
@@ -18,7 +18,6 @@
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>
 #include <device/pci_def.h>
-#include <string.h>
 #include <device/mmio.h>
 #include <delay.h>
 #include <hwilib.h>
diff --git a/src/drivers/sil/3114/sil_sata.c b/src/drivers/sil/3114/sil_sata.c
index db8de68303d4..4908413fb805 100644
--- a/src/drivers/sil/3114/sil_sata.c
+++ b/src/drivers/sil/3114/sil_sata.c
@@ -16,8 +16,6 @@
 
 #include <delay.h>
 #include <stdlib.h>
-#include <string.h>
-
 #include <console/console.h>
 #include <device/device.h>
 #include <device/pci.h>
diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c
index 489b82ff46ae..6f2014b155ce 100644
--- a/src/drivers/smmstore/store.c
+++ b/src/drivers/smmstore/store.c
@@ -19,7 +19,6 @@
 #include <commonlib/region.h>
 #include <console/console.h>
 #include <smmstore.h>
-#include <string.h>
 
 /*
  * The region format is still not finalized, but so far it looks like this:
diff --git a/src/drivers/spi/flashconsole.c b/src/drivers/spi/flashconsole.c
index 2626ec549a5f..3109012bd474 100644
--- a/src/drivers/spi/flashconsole.c
+++ b/src/drivers/spi/flashconsole.c
@@ -19,7 +19,6 @@
 #include <fmap.h>
 #include <console/console.h>
 #include <console/flash.h>
-#include <string.h>
 
 #define LINE_BUFFER_SIZE 128
 #define READ_BUFFER_SIZE 0x100
diff --git a/src/drivers/spi/tpm/tis.c b/src/drivers/spi/tpm/tis.c
index 40bf27dee2c1..b50ab0a88cf9 100644
--- a/src/drivers/spi/tpm/tis.c
+++ b/src/drivers/spi/tpm/tis.c
@@ -6,7 +6,6 @@
 
 #include <arch/early_variables.h>
 #include <console/console.h>
-#include <string.h>
 #include <security/tpm/tis.h>
 
 #include "tpm.h"
diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c
index 8c63d2aa6c67..31a7a7f30b5e 100644
--- a/src/drivers/usb/acpi/usb_acpi.c
+++ b/src/drivers/usb/acpi/usb_acpi.c
@@ -20,7 +20,6 @@
 #include <device/device.h>
 #include <device/path.h>
 #include <stdint.h>
-#include <string.h>
 #include "chip.h"
 
 static bool usb_acpi_add_gpios_to_crs(struct drivers_usb_acpi_config *cfg)
diff --git a/src/drivers/xgi/common/xgi_coreboot.c b/src/drivers/xgi/common/xgi_coreboot.c
index 795b8a5fe02d..745baa2d88a4 100644
--- a/src/drivers/xgi/common/xgi_coreboot.c
+++ b/src/drivers/xgi/common/xgi_coreboot.c
@@ -17,7 +17,6 @@
  */
 #include <delay.h>
 #include <stdlib.h>
-#include <string.h>
 #include <vbe.h>
 
 #include <console/console.h>
diff --git a/src/drivers/xgi/common/xgi_coreboot.h b/src/drivers/xgi/common/xgi_coreboot.h
index 39e74d1e47dc..dc8f49eb54c5 100644
--- a/src/drivers/xgi/common/xgi_coreboot.h
+++ b/src/drivers/xgi/common/xgi_coreboot.h
@@ -22,7 +22,6 @@
 #include <delay.h>
 #include <stdlib.h>
 #include <stdint.h>
-#include <string.h>
 #include <arch/io.h>
 #include <device/mmio.h>
 
diff --git a/src/drivers/xgi/z9s/z9s.c b/src/drivers/xgi/z9s/z9s.c
index 3544b8d69e6e..3b468114c9ec 100644
--- a/src/drivers/xgi/z9s/z9s.c
+++ b/src/drivers/xgi/z9s/z9s.c
@@ -14,7 +14,6 @@
  */
 #include <delay.h>
 #include <stdlib.h>
-#include <string.h>
 
 #include <console/console.h>
 #include <device/device.h>