summaryrefslogtreecommitdiffstats
path: root/src/drivers
diff options
context:
space:
mode:
authorSubrata Banik <subratabanik@google.com>2024-04-01 21:43:48 +0530
committerSubrata Banik <subratabanik@google.com>2024-04-04 06:28:18 +0000
commit20dd04872fb902658560fbb0c70d2030c8ead453 (patch)
tree2647cdddb68aca279c00d5b6f5d97f1382199f8b /src/drivers
parent6daf0b3fdaf4f09bc1701b610a556cb665a1eb4b (diff)
downloadcoreboot-20dd04872fb902658560fbb0c70d2030c8ead453.tar.gz
coreboot-20dd04872fb902658560fbb0c70d2030c8ead453.tar.bz2
coreboot-20dd04872fb902658560fbb0c70d2030c8ead453.zip
drivers/intel: Align FSP debug handler with EFI calling convention
Ensures the FSP debug handler adheres to the EFI calling convention, enabling seamless integration with coreboot infrastructure. This is critical for 64-bit coreboot and FSP communications. BUG=b:242829490 TEST=FSP debug logs successfully captured via coreboot event handler. Change-Id: I9085a6c7d50e58fb56cbbc61da3a0af094d0dc05 Signed-off-by: Subrata Banik <subratabanik@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81621 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Dinesh Gehlot <digehlot@google.com> Reviewed-by: Ronak Kanabar <ronak.kanabar@intel.com>
Diffstat (limited to 'src/drivers')
-rw-r--r--src/drivers/intel/fsp2_0/fsp_debug_event.c2
-rw-r--r--src/drivers/intel/fsp2_0/include/fsp/fsp_debug_event.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/drivers/intel/fsp2_0/fsp_debug_event.c b/src/drivers/intel/fsp2_0/fsp_debug_event.c
index 2ebecc0e5124..4b3e151ad83b 100644
--- a/src/drivers/intel/fsp2_0/fsp_debug_event.c
+++ b/src/drivers/intel/fsp2_0/fsp_debug_event.c
@@ -17,7 +17,7 @@ static efi_return_status_t print_fsp_string_data(const efi_status_code_data_t *d
return FSP_SUCCESS;
}
-efi_return_status_t fsp_debug_event_handler(efi_status_code_type_t ignored1,
+__efiapi efi_return_status_t fsp_debug_event_handler(efi_status_code_type_t ignored1,
efi_status_code_value_t ignored2, efi_uint32_t ignored3, efi_guid_t *ignored4,
efi_status_code_data_t *data)
{
diff --git a/src/drivers/intel/fsp2_0/include/fsp/fsp_debug_event.h b/src/drivers/intel/fsp2_0/include/fsp/fsp_debug_event.h
index 7d50c1e68f2c..149629a12136 100644
--- a/src/drivers/intel/fsp2_0/include/fsp/fsp_debug_event.h
+++ b/src/drivers/intel/fsp2_0/include/fsp/fsp_debug_event.h
@@ -12,7 +12,7 @@
#include <fsp/soc_binding.h>
/* fsp debug event handler */
-efi_return_status_t fsp_debug_event_handler(efi_status_code_type_t ignored1,
+__efiapi efi_return_status_t fsp_debug_event_handler(efi_status_code_type_t ignored1,
efi_status_code_value_t ignored2, efi_uint32_t ignored3, efi_guid_t *ignored4,
efi_status_code_data_t *data);