diff options
| author | Sathya Prakash M R <sathya.prakash.m.r@intel.com> | 2021-07-12 16:30:37 +0530 |
|---|---|---|
| committer | Subrata Banik <subrata.banik@intel.com> | 2021-08-13 04:15:32 +0000 |
| commit | 1f19ef54e43f791350ac36b3004a0f2f80fa9227 (patch) | |
| tree | 24f521801059526d32f7bbe3ffb7e25562f59688 /src/mainboard/intel/adlrvp | |
| parent | f9d7dc7ed3de9383740295871c8adde66c688425 (diff) | |
| download | coreboot-1f19ef54e43f791350ac36b3004a0f2f80fa9227.tar.gz coreboot-1f19ef54e43f791350ac36b3004a0f2f80fa9227.tar.bz2 coreboot-1f19ef54e43f791350ac36b3004a0f2f80fa9227.zip | |
mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
With current setting Display audio codec probe fails.
Hence HDMI/DP audio fails.
Earlier, with FSP 2037 was used the mode was incorrectly programmed to 4T
This setting was carried ahead with below change:
Commit : 50f8b4ebdd7db8077b87ab7686637599c9d93af3
The issue was fixed in later FSPs and with current
FSP v2237, we need to set the TMODE to 8T as per spec.
TEST=Verify HDMI/DP Playback on ADL P RVP
Fixes: 50f8b4ebdd7db8077b87ab7686637599c9d93af3
(soc/intel/alderlake: Add enum for HDA audio configuration)
Signed-off-by: Sathya Prakash M R <sathya.prakash.m.r@intel.com>
Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56208
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-by: Balaji Manigandan <balaji.manigandan@intel.com>
Reviewed-by: Meera Ravindranath <meera.ravindranath@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard/intel/adlrvp')
| -rw-r--r-- | src/mainboard/intel/adlrvp/devicetree.cb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/intel/adlrvp/devicetree.cb b/src/mainboard/intel/adlrvp/devicetree.cb index d4a2eb72cf8c..c9d7da6cbcae 100644 --- a/src/mainboard/intel/adlrvp/devicetree.cb +++ b/src/mainboard/intel/adlrvp/devicetree.cb @@ -169,7 +169,7 @@ chip soc/intel/alderlake # HD Audio register "PchHdaDspEnable" = "1" - register "PchHdaIDispLinkTmode" = "HDA_TMODE_4T" + register "PchHdaIDispLinkTmode" = "HDA_TMODE_8T" register "PchHdaIDispLinkFrequency" = "HDA_LINKFREQ_96MHZ" register "PchHdaIDispCodecEnable" = "1" |