summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2023-11-10 18:50:39 +0100
committerFelix Singer <service+coreboot-gerrit@felixsinger.de>2023-11-12 04:52:40 +0000
commit173922fc88e7c4e06ef903f2445919cb678324fb (patch)
treefd4c9edd5822db76a6afabc1400946c196b19009 /src
parent2a87ef1eca56ed6b215bd6c4e0beabab670434ee (diff)
downloadcoreboot-173922fc88e7c4e06ef903f2445919cb678324fb.tar.gz
coreboot-173922fc88e7c4e06ef903f2445919cb678324fb.tar.bz2
coreboot-173922fc88e7c4e06ef903f2445919cb678324fb.zip
mainboards: Drop stale comment about enumerate_buses()
There is no enumerate_buses() today and also no trace of it in our repository. Also, in current terms, mainboard_enable() is called as the very first thing in our enumeration so the comment seems misleading. Change-Id: Iae620f83c8166c1cfc8b9fb9ef4a7025987bf1be Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79003 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/bostentech/gbyt4/mainboard.c3
-rw-r--r--src/mainboard/facebook/fbg1701/mainboard.c4
-rw-r--r--src/mainboard/facebook/monolith/mainboard.c4
-rw-r--r--src/mainboard/getac/p470/mainboard.c2
-rw-r--r--src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c3
-rw-r--r--src/mainboard/google/auron/mainboard.c3
-rw-r--r--src/mainboard/google/beltino/mainboard.c3
-rw-r--r--src/mainboard/google/butterfly/mainboard.c3
-rw-r--r--src/mainboard/google/cyan/mainboard.c4
-rw-r--r--src/mainboard/google/glados/mainboard.c4
-rw-r--r--src/mainboard/google/jecht/mainboard.c3
-rw-r--r--src/mainboard/google/link/mainboard.c3
-rw-r--r--src/mainboard/google/parrot/mainboard.c3
-rw-r--r--src/mainboard/google/rambi/mainboard.c3
-rw-r--r--src/mainboard/google/slippy/mainboard.c3
-rw-r--r--src/mainboard/google/stout/mainboard.c3
-rw-r--r--src/mainboard/ibase/mb899/mainboard.c3
-rw-r--r--src/mainboard/intel/baskingridge/mainboard.c3
-rw-r--r--src/mainboard/intel/emeraldlake2/mainboard.c3
-rw-r--r--src/mainboard/intel/kblrvp/mainboard.c4
-rw-r--r--src/mainboard/intel/kunimitsu/mainboard.c4
-rw-r--r--src/mainboard/intel/strago/mainboard.c4
-rw-r--r--src/mainboard/intel/wtm2/mainboard.c3
-rw-r--r--src/mainboard/kontron/986lcd-m/mainboard.c3
-rw-r--r--src/mainboard/kontron/ktqm77/mainboard.c4
-rw-r--r--src/mainboard/lenovo/t520/mainboard.c2
-rw-r--r--src/mainboard/lenovo/t530/mainboard.c3
-rw-r--r--src/mainboard/lenovo/x220/mainboard.c3
-rw-r--r--src/mainboard/lenovo/x230/mainboard.c3
-rw-r--r--src/mainboard/samsung/lumpy/mainboard.c3
-rw-r--r--src/mainboard/samsung/stumpy/mainboard.c3
31 files changed, 0 insertions, 99 deletions
diff --git a/src/mainboard/bostentech/gbyt4/mainboard.c b/src/mainboard/bostentech/gbyt4/mainboard.c
index da7106aafbb9..100cfa514ef6 100644
--- a/src/mainboard/bostentech/gbyt4/mainboard.c
+++ b/src/mainboard/bostentech/gbyt4/mainboard.c
@@ -3,9 +3,6 @@
#include <device/device.h>
#include <soc/int15.h>
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
/* Install custom int15 handler for VGA OPROM */
diff --git a/src/mainboard/facebook/fbg1701/mainboard.c b/src/mainboard/facebook/fbg1701/mainboard.c
index 1ab13e10ce78..7838bab5283a 100644
--- a/src/mainboard/facebook/fbg1701/mainboard.c
+++ b/src/mainboard/facebook/fbg1701/mainboard.c
@@ -20,10 +20,6 @@ static void mainboard_reserve_resources(struct device *dev)
res->flags = IORESOURCE_IRQ | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
}
-/*
- * mainboard_enable is executed as first thing after
- * enumerate_buses().
- */
static void mainboard_enable(struct device *dev)
{
mainboard_reserve_resources(dev);
diff --git a/src/mainboard/facebook/monolith/mainboard.c b/src/mainboard/facebook/monolith/mainboard.c
index 1ab13e10ce78..7838bab5283a 100644
--- a/src/mainboard/facebook/monolith/mainboard.c
+++ b/src/mainboard/facebook/monolith/mainboard.c
@@ -20,10 +20,6 @@ static void mainboard_reserve_resources(struct device *dev)
res->flags = IORESOURCE_IRQ | IORESOURCE_ASSIGNED | IORESOURCE_FIXED;
}
-/*
- * mainboard_enable is executed as first thing after
- * enumerate_buses().
- */
static void mainboard_enable(struct device *dev)
{
mainboard_reserve_resources(dev);
diff --git a/src/mainboard/getac/p470/mainboard.c b/src/mainboard/getac/p470/mainboard.c
index baabb4bd2771..75f736a6b8d6 100644
--- a/src/mainboard/getac/p470/mainboard.c
+++ b/src/mainboard/getac/p470/mainboard.c
@@ -40,8 +40,6 @@ static void mainboard_init(struct device *dev)
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_TXT_STRETCH, 0, 3);
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses(). Is there no mainboard_init()?
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c b/src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c
index 99207c1c736d..60261862d05e 100644
--- a/src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c
+++ b/src/mainboard/gigabyte/ga-b75m-d3h/mainboard.c
@@ -4,9 +4,6 @@
#include <drivers/intel/gma/int15.h>
#include <southbridge/intel/bd82x6x/pch.h>
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_NONE,
diff --git a/src/mainboard/google/auron/mainboard.c b/src/mainboard/google/auron/mainboard.c
index f465d0775d89..ed2e7b889c0b 100644
--- a/src/mainboard/google/auron/mainboard.c
+++ b/src/mainboard/google/auron/mainboard.c
@@ -21,9 +21,6 @@ static int mainboard_smbios_data(struct device *dev, int *handle,
return variant_smbios_data(dev, handle, current);
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/beltino/mainboard.c b/src/mainboard/google/beltino/mainboard.c
index b35e00540580..7d3da78d4674 100644
--- a/src/mainboard/google/beltino/mainboard.c
+++ b/src/mainboard/google/beltino/mainboard.c
@@ -18,9 +18,6 @@ static void mainboard_init(struct device *dev)
lan_init();
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c
index 67f371c65626..ac0f57b3aa82 100644
--- a/src/mainboard/google/butterfly/mainboard.c
+++ b/src/mainboard/google/butterfly/mainboard.c
@@ -248,9 +248,6 @@ static int butterfly_onboard_smbios_data(struct device *dev, int *handle,
return len;
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/cyan/mainboard.c b/src/mainboard/google/cyan/mainboard.c
index 1e0006ce019a..6a3f4803ce2e 100644
--- a/src/mainboard/google/cyan/mainboard.c
+++ b/src/mainboard/google/cyan/mainboard.c
@@ -8,10 +8,6 @@ static void mainboard_init(struct device *dev)
mainboard_ec_init();
}
-/*
- * mainboard_enable is executed as first thing after
- * enumerate_buses().
- */
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/glados/mainboard.c b/src/mainboard/google/glados/mainboard.c
index faa80b9cbb77..9f370527019a 100644
--- a/src/mainboard/google/glados/mainboard.c
+++ b/src/mainboard/google/glados/mainboard.c
@@ -87,10 +87,6 @@ static unsigned long mainboard_write_acpi_tables(
return end_addr;
}
-/*
- * mainboard_enable is executed as first thing after
- * enumerate_buses().
- */
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/jecht/mainboard.c b/src/mainboard/google/jecht/mainboard.c
index 3c255b7871e0..0b3ae01c13b0 100644
--- a/src/mainboard/google/jecht/mainboard.c
+++ b/src/mainboard/google/jecht/mainboard.c
@@ -8,9 +8,6 @@ static void mainboard_init(struct device *dev)
lan_init();
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/link/mainboard.c b/src/mainboard/google/link/mainboard.c
index 1f9da88e5cbe..c31ab110a29a 100644
--- a/src/mainboard/google/link/mainboard.c
+++ b/src/mainboard/google/link/mainboard.c
@@ -162,9 +162,6 @@ static int link_onboard_smbios_data(struct device *dev, int *handle,
return len;
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/parrot/mainboard.c b/src/mainboard/google/parrot/mainboard.c
index eeb3ce448714..f921812687ff 100644
--- a/src/mainboard/google/parrot/mainboard.c
+++ b/src/mainboard/google/parrot/mainboard.c
@@ -53,9 +53,6 @@ static int parrot_onboard_smbios_data(struct device *dev, int *handle,
return len;
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/rambi/mainboard.c b/src/mainboard/google/rambi/mainboard.c
index 8f887e8d0f18..df27e39724a7 100644
--- a/src/mainboard/google/rambi/mainboard.c
+++ b/src/mainboard/google/rambi/mainboard.c
@@ -45,9 +45,6 @@ static int mainboard_smbios_data(struct device *dev, int *handle,
return len;
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/slippy/mainboard.c b/src/mainboard/google/slippy/mainboard.c
index 47f071c2a4cb..8d470f4ba6d4 100644
--- a/src/mainboard/google/slippy/mainboard.c
+++ b/src/mainboard/google/slippy/mainboard.c
@@ -58,9 +58,6 @@ static int mainboard_smbios_data(struct device *dev, int *handle,
return len;
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c
index ae68a78dcbc2..e1ea7c265fc2 100644
--- a/src/mainboard/google/stout/mainboard.c
+++ b/src/mainboard/google/stout/mainboard.c
@@ -35,9 +35,6 @@ static void mainboard_init(struct device *dev)
pci_write_config8(ethernet_dev, 0x81, 0x01);
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/ibase/mb899/mainboard.c b/src/mainboard/ibase/mb899/mainboard.c
index d2a5b780279b..881310403fab 100644
--- a/src/mainboard/ibase/mb899/mainboard.c
+++ b/src/mainboard/ibase/mb899/mainboard.c
@@ -4,9 +4,6 @@
#include <drivers/intel/gma/int15.h>
#include "superio_hwm.h"
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 3);
diff --git a/src/mainboard/intel/baskingridge/mainboard.c b/src/mainboard/intel/baskingridge/mainboard.c
index 73fa9aa65cc7..0f1db2478e1a 100644
--- a/src/mainboard/intel/baskingridge/mainboard.c
+++ b/src/mainboard/intel/baskingridge/mainboard.c
@@ -12,9 +12,6 @@ void mainboard_suspend_resume(void)
apm_control(APM_CNT_FINALIZE);
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
diff --git a/src/mainboard/intel/emeraldlake2/mainboard.c b/src/mainboard/intel/emeraldlake2/mainboard.c
index b610e2ef6d7a..d08ef3085053 100644
--- a/src/mainboard/intel/emeraldlake2/mainboard.c
+++ b/src/mainboard/intel/emeraldlake2/mainboard.c
@@ -4,9 +4,6 @@
#include <drivers/intel/gma/int15.h>
#include <southbridge/intel/bd82x6x/pch.h>
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
diff --git a/src/mainboard/intel/kblrvp/mainboard.c b/src/mainboard/intel/kblrvp/mainboard.c
index ceaaa0566c78..c3c9169b0660 100644
--- a/src/mainboard/intel/kblrvp/mainboard.c
+++ b/src/mainboard/intel/kblrvp/mainboard.c
@@ -12,10 +12,6 @@ static void mainboard_init(struct device *dev)
mainboard_ec_init();
}
-/*
- * mainboard_enable is executed as first thing after
- * enumerate_buses().
- */
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/intel/kunimitsu/mainboard.c b/src/mainboard/intel/kunimitsu/mainboard.c
index b7c61f50584a..19d6a724bf23 100644
--- a/src/mainboard/intel/kunimitsu/mainboard.c
+++ b/src/mainboard/intel/kunimitsu/mainboard.c
@@ -73,10 +73,6 @@ static unsigned long mainboard_write_acpi_tables(
return end_addr;
}
-/*
- * mainboard_enable is executed as first thing after
- * enumerate_buses().
- */
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/intel/strago/mainboard.c b/src/mainboard/intel/strago/mainboard.c
index 447ae3135585..eee89b08c536 100644
--- a/src/mainboard/intel/strago/mainboard.c
+++ b/src/mainboard/intel/strago/mainboard.c
@@ -9,10 +9,6 @@ static void mainboard_init(struct device *dev)
mainboard_ec_init();
}
-/*
- * mainboard_enable is executed as first thing after
- * enumerate_buses().
- */
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/intel/wtm2/mainboard.c b/src/mainboard/intel/wtm2/mainboard.c
index d17645ff03e4..41c02357ec83 100644
--- a/src/mainboard/intel/wtm2/mainboard.c
+++ b/src/mainboard/intel/wtm2/mainboard.c
@@ -3,9 +3,6 @@
#include <device/device.h>
#include <drivers/intel/gma/int15.h>
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c
index f621f9bd7c45..dbdd059af931 100644
--- a/src/mainboard/kontron/986lcd-m/mainboard.c
+++ b/src/mainboard/kontron/986lcd-m/mainboard.c
@@ -121,9 +121,6 @@ static void hwm_setup(void)
pnp_write_hwm5_index(hwm_base, 0x40, 0x01); /* Init, but no SMI# */
}
-/* mainboard_enable is executed as first thing after */
-/* enumerate_buses(). */
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 3);
diff --git a/src/mainboard/kontron/ktqm77/mainboard.c b/src/mainboard/kontron/ktqm77/mainboard.c
index f8ef53834f97..27aa3b532868 100644
--- a/src/mainboard/kontron/ktqm77/mainboard.c
+++ b/src/mainboard/kontron/ktqm77/mainboard.c
@@ -138,10 +138,6 @@ static int int15_handler(void)
#endif
-
-/* mainboard_enable is executed as first thing after */
-/* enumerate_buses(). */
-
static void mainboard_enable(struct device *dev)
{
#if CONFIG(PCI_OPTION_ROM_RUN_YABEL) || \
diff --git a/src/mainboard/lenovo/t520/mainboard.c b/src/mainboard/lenovo/t520/mainboard.c
index 39790f298a7f..50c944e341d5 100644
--- a/src/mainboard/lenovo/t520/mainboard.c
+++ b/src/mainboard/lenovo/t520/mainboard.c
@@ -3,8 +3,6 @@
#include <device/device.h>
#include <drivers/intel/gma/int15.h>
-/* mainboard_enable is executed as first thing after
-enumerate_buses(). */
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
diff --git a/src/mainboard/lenovo/t530/mainboard.c b/src/mainboard/lenovo/t530/mainboard.c
index b33e22920eb9..50c944e341d5 100644
--- a/src/mainboard/lenovo/t530/mainboard.c
+++ b/src/mainboard/lenovo/t530/mainboard.c
@@ -3,9 +3,6 @@
#include <device/device.h>
#include <drivers/intel/gma/int15.h>
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
diff --git a/src/mainboard/lenovo/x220/mainboard.c b/src/mainboard/lenovo/x220/mainboard.c
index b33e22920eb9..50c944e341d5 100644
--- a/src/mainboard/lenovo/x220/mainboard.c
+++ b/src/mainboard/lenovo/x220/mainboard.c
@@ -3,9 +3,6 @@
#include <device/device.h>
#include <drivers/intel/gma/int15.h>
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
diff --git a/src/mainboard/lenovo/x230/mainboard.c b/src/mainboard/lenovo/x230/mainboard.c
index b33e22920eb9..50c944e341d5 100644
--- a/src/mainboard/lenovo/x230/mainboard.c
+++ b/src/mainboard/lenovo/x230/mainboard.c
@@ -3,9 +3,6 @@
#include <device/device.h>
#include <drivers/intel/gma/int15.h>
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
diff --git a/src/mainboard/samsung/lumpy/mainboard.c b/src/mainboard/samsung/lumpy/mainboard.c
index 0605b5ffa4b0..da2623418a27 100644
--- a/src/mainboard/samsung/lumpy/mainboard.c
+++ b/src/mainboard/samsung/lumpy/mainboard.c
@@ -64,9 +64,6 @@ static int lumpy_onboard_smbios_data(struct device *dev, int *handle,
return len;
}
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
dev->ops->init = mainboard_init;
diff --git a/src/mainboard/samsung/stumpy/mainboard.c b/src/mainboard/samsung/stumpy/mainboard.c
index b610e2ef6d7a..d08ef3085053 100644
--- a/src/mainboard/samsung/stumpy/mainboard.c
+++ b/src/mainboard/samsung/stumpy/mainboard.c
@@ -4,9 +4,6 @@
#include <drivers/intel/gma/int15.h>
#include <southbridge/intel/bd82x6x/pch.h>
-// mainboard_enable is executed as first thing after
-// enumerate_buses().
-
static void mainboard_enable(struct device *dev)
{
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_CENTERING, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);