diff options
| author | Shelley Chen <shchen@google.com> | 2024-01-08 14:25:08 -0800 |
|---|---|---|
| committer | Shelley Chen <shchen@google.com> | 2024-01-13 01:50:50 +0000 |
| commit | c881c9ed2b24852233045f0bd02705631aef12dc (patch) | |
| tree | ea0b98a42368100848aad96c3adb59fccbbb887f /src | |
| parent | 164cf293554a640f11d71b5142b5ce00cbde7220 (diff) | |
| download | coreboot-c881c9ed2b24852233045f0bd02705631aef12dc.tar.gz coreboot-c881c9ed2b24852233045f0bd02705631aef12dc.tar.bz2 coreboot-c881c9ed2b24852233045f0bd02705631aef12dc.zip | |
mb/google/brox: Disable package c state demotion
This needs to be disabled for RPL otherwise we'll hit the assertion:
[EMERG] ASSERTION ERROR: file 'src/soc/intel/alderlake/fsp_params.c', line 1066
There is a comment in the referenced file/line in the assertion that
says that "C state demotion must be disabled for Raptorlake J0 and Q0
SKUs." So, disabling it.
BUG=b:311450057,b:300690448
BRANCH=None
TEST=Tested that we didn't hit this assertion on the device after this
change
Change-Id: Ib7b2484de2d84c980550fd951f1e30efab0ee197
Signed-off-by: Shelley Chen <shchen@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79855
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-by: Eric Lai <ericllai@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb index 23db754ca527..552164ad5679 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb +++ b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb @@ -14,6 +14,10 @@ chip soc/intel/alderlake # S0ix enable register "s0ix_enable" = "1" + # Disable package C state demotion on Raptorlake as a W/A for S0ix issues + # seen on J0 and Q0 SKUs + register "disable_package_c_state_demotion" = "1" + # DPTF enable register "dptf_enable" = "1" |