diff options
| author | Matt DeVillier <matt.devillier@amd.corp-partner.google.com> | 2022-09-09 11:30:00 -0500 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-09-14 20:52:02 +0000 |
| commit | 275a9a3d7e89e170ac5c5e7a88bec7152e318102 (patch) | |
| tree | 6c5555f39c1479a2443a24264907f462ef3a137c /util | |
| parent | badea79500b46f00f07308af17b55b5adfd0ce81 (diff) | |
| download | coreboot-275a9a3d7e89e170ac5c5e7a88bec7152e318102.tar.gz coreboot-275a9a3d7e89e170ac5c5e7a88bec7152e318102.tar.bz2 coreboot-275a9a3d7e89e170ac5c5e7a88bec7152e318102.zip | |
util/lint: Add a check for touchpads using the "probed" flag
As of commit 2cf52d80a6ec ("mb/*/{device,override}tree: Set touchpads to
use detect (vs probed) flag") all touchpads in the tree have been
switched from using the 'probed' flag to 'detect.' Add a lint check to
ensure no touchpads are added with the probed flag.
TEST=manually change one touchpad to use 'probed' flag and ensure lint
check catches it.
Change-Id: Ie0aee2e3778fc56c6c21c97995738a147a1fa0d4
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67486
Reviewed-by: Martin Roth <martin.roth@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'util')
| -rwxr-xr-x | util/lint/lint-stable-028-touchpad-probed-warning | 29 |
1 files changed, 29 insertions, 0 deletions
diff --git a/util/lint/lint-stable-028-touchpad-probed-warning b/util/lint/lint-stable-028-touchpad-probed-warning new file mode 100755 index 000000000000..3878dfba2dd3 --- /dev/null +++ b/util/lint/lint-stable-028-touchpad-probed-warning @@ -0,0 +1,29 @@ +#!/usr/bin/env sh +# SPDX-License-Identifier: GPL-2.0-or-later +# +# DESCR: Check that no touchpad uses the "probed" flag + +FAIL=0 + +TESTFILE1="src/mainboard/google/eve/devicetree.cb" +EXPECTED_FAILURES=1 + +# Configure to make sure tests fail +if [ "$1" = "--test" ]; then + sed -i.bak "/^.*register \"generic.desc\" = \"\"Touchpad\"\"/a \t\t\t\tregister \"generic.probed\" = \"1\"" "${TESTFILE1}" + echo "Expect ${EXPECTED_FAILURES} failures." + exit 0 +elif [ "$1" = "--reset" ]; then + mv "${TESTFILE1}.bak" "${TESTFILE1}" + exit 0 +fi + +for f in `find src/mainboard/ -name *tree.cb`; do + if grep -B8 "probed\" = \"1\"" $f | grep -q "Touchpad"; then + echo "ERROR: in $f:" + echo " Use of the 'probed' flag for touchpads is deprecated; use 'detect' instead" + FAIL=1 + fi +done + +exit $FAIL |