From 5b0929f9d7e6ec4339471be365416a1991baae33 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Sat, 3 Jun 2023 16:42:46 +0530 Subject: vboot: Drop argument to select slot from `vb2ex_ec_protect()` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit vboot code changes have eliminated the redundant call to WP the EC-RO region as protecting RW flash implies protecting both RO and RW flash, so the call to protect RO is redundant. google/rex currently takes about 17 ms to lock down the EC. Along with vboot changes, this patch drops argument to choose between RO and RW slot to protect while calling into `vb2ex_ec_protect()`. It ensures vb2ex_ec_protect() is explicitly meant for protecting RW regions. w/o this patch: 517:waiting for EC to allow higher power draw 846,196 (17,297) w/ this patch: 517:waiting for EC to allow higher power draw 838,258 (9,719) Additionally, update vboot submodule to upstream main to avoid the compilation error. Updating from commit id 35f50c3154e5: Fix build error when compiling without -DNDEBUG to commit id 034907b279c9db: vboot_reference: eliminate redundant call to write protect EC-RO Change-Id: I2974f0cb43ba800c2aaeac4876ebaa052b5ee793 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/75521 Tested-by: build bot (Jenkins) Reviewed-by: Himanshu Sahdev Reviewed-by: Harsha B R Reviewed-by: Julius Werner --- 3rdparty/vboot | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '3rdparty') diff --git a/3rdparty/vboot b/3rdparty/vboot index 35f50c3154e5..034907b279c9 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 35f50c3154e58821cc027bf13be2b949bc4c90f3 +Subproject commit 034907b279c9db1faa7dd5633fa1140436433768 -- cgit v1.2.3