From 14643b33b0f7ea9cde6ce8230793562d4a1b475c Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 17 Oct 2021 13:21:05 +0200 Subject: soc/intel/*/acpi.c: Don't copy structs with `memcpy()` A regular assignment works just as well and also allows type-checking. Change-Id: Id772771f000ba3bad5d4af05f5651c0f0ee43d6d Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/58390 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel --- src/soc/intel/alderlake/acpi.c | 2 +- src/soc/intel/cannonlake/acpi.c | 2 +- src/soc/intel/elkhartlake/acpi.c | 2 +- src/soc/intel/icelake/acpi.c | 2 +- src/soc/intel/jasperlake/acpi.c | 2 +- src/soc/intel/tigerlake/acpi.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/soc/intel/alderlake/acpi.c b/src/soc/intel/alderlake/acpi.c index 9f4fa880a05d..075b4d66238f 100644 --- a/src/soc/intel/alderlake/acpi.c +++ b/src/soc/intel/alderlake/acpi.c @@ -131,7 +131,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries) } for (i = 0; i < *entries; i++) { - memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t)); + map[i] = cstate_map[set[i]]; map[i].ctype = i + 1; } return map; diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c index d0f38747cbcd..5e2d1425d32e 100644 --- a/src/soc/intel/cannonlake/acpi.c +++ b/src/soc/intel/cannonlake/acpi.c @@ -131,7 +131,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries) } for (i = 0; i < *entries; i++) { - memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t)); + map[i] = cstate_map[set[i]]; map[i].ctype = i + 1; } return map; diff --git a/src/soc/intel/elkhartlake/acpi.c b/src/soc/intel/elkhartlake/acpi.c index 7531331d25f0..e44a5d4ebaa7 100644 --- a/src/soc/intel/elkhartlake/acpi.c +++ b/src/soc/intel/elkhartlake/acpi.c @@ -130,7 +130,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries) } for (i = 0; i < *entries; i++) { - memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t)); + map[i] = cstate_map[set[i]]; map[i].ctype = i + 1; } return map; diff --git a/src/soc/intel/icelake/acpi.c b/src/soc/intel/icelake/acpi.c index fa6d038a5159..f822e8323b2f 100644 --- a/src/soc/intel/icelake/acpi.c +++ b/src/soc/intel/icelake/acpi.c @@ -127,7 +127,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries) } for (i = 0; i < *entries; i++) { - memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t)); + map[i] = cstate_map[set[i]]; map[i].ctype = i + 1; } return map; diff --git a/src/soc/intel/jasperlake/acpi.c b/src/soc/intel/jasperlake/acpi.c index cc7b8ae62fdc..28ed1f197043 100644 --- a/src/soc/intel/jasperlake/acpi.c +++ b/src/soc/intel/jasperlake/acpi.c @@ -130,7 +130,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries) } for (i = 0; i < *entries; i++) { - memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t)); + map[i] = cstate_map[set[i]]; map[i].ctype = i + 1; } return map; diff --git a/src/soc/intel/tigerlake/acpi.c b/src/soc/intel/tigerlake/acpi.c index e560f11f6966..bf032693448d 100644 --- a/src/soc/intel/tigerlake/acpi.c +++ b/src/soc/intel/tigerlake/acpi.c @@ -130,7 +130,7 @@ acpi_cstate_t *soc_get_cstate_map(size_t *entries) } for (i = 0; i < *entries; i++) { - memcpy(&map[i], &cstate_map[set[i]], sizeof(acpi_cstate_t)); + map[i] = cstate_map[set[i]]; map[i].ctype = i + 1; } return map; -- cgit v1.2.3