From 35c3ae3bf4a43a36028fbd9e34ea4cb758029bf1 Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Thu, 27 Oct 2022 12:25:12 +0200 Subject: treewide: Add 'IWYU pragma: export' comment This pragma says to IWYU (Include What You Use) that the current file is supposed to provide commented headers. Change-Id: I482c645f6b5f955e532ad94def1b2f74f15ca908 Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/68332 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh --- src/arch/x86/include/arch/cpu.h | 2 +- src/include/cbmem.h | 2 +- src/include/console/console.h | 2 +- src/include/cpu/cpu.h | 2 +- src/include/cpu/x86/msr.h | 2 +- src/include/device/mmio.h | 2 +- src/include/device/pci.h | 11 ++++++----- src/include/device/pci_ops.h | 2 +- src/include/device/pnp.h | 4 ++-- src/include/string.h | 4 ++-- src/include/types.h | 2 ++ src/southbridge/intel/bd82x6x/pch.h | 2 +- src/southbridge/intel/i82801gx/i82801gx.h | 2 +- src/southbridge/intel/i82801ix/i82801ix.h | 2 +- src/southbridge/intel/i82801jx/i82801jx.h | 2 +- src/southbridge/intel/ibexpeak/pch.h | 3 +-- src/southbridge/intel/lynxpoint/pch.h | 3 +-- 17 files changed, 25 insertions(+), 24 deletions(-) diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index 3402215882a9..7c1a52eff5a2 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -4,7 +4,7 @@ #define ARCH_CPU_H #include -#include +#include /* IWYU pragma: export */ /* * EFLAGS bits diff --git a/src/include/cbmem.h b/src/include/cbmem.h index 5b5191aab204..40a0acb510d8 100644 --- a/src/include/cbmem.h +++ b/src/include/cbmem.h @@ -3,7 +3,7 @@ #ifndef _CBMEM_H_ #define _CBMEM_H_ -#include +#include /* IWYU pragma: export */ #include #include #include diff --git a/src/include/console/console.h b/src/include/console/console.h index 49bce6147053..6f44d7f95c1a 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -8,7 +8,7 @@ #include /* console.h is supposed to provide the log levels defined in here: */ -#include +#include /* IWYU pragma: export */ #define RAM_DEBUG (CONFIG(DEBUG_RAM_SETUP) ? BIOS_DEBUG : BIOS_NEVER) #define RAM_SPEW (CONFIG(DEBUG_RAM_SETUP) ? BIOS_SPEW : BIOS_NEVER) diff --git a/src/include/cpu/cpu.h b/src/include/cpu/cpu.h index 66103684ba1f..e668de8ff42d 100644 --- a/src/include/cpu/cpu.h +++ b/src/include/cpu/cpu.h @@ -3,7 +3,7 @@ #ifndef CPU_CPU_H #define CPU_CPU_H -#include +#include /* IWYU pragma: export */ #include void cpu_initialize(unsigned int cpu_index); diff --git a/src/include/cpu/x86/msr.h b/src/include/cpu/x86/msr.h index 999fdaae5b48..f4e39859cf8e 100644 --- a/src/include/cpu/x86/msr.h +++ b/src/include/cpu/x86/msr.h @@ -3,7 +3,7 @@ #ifndef CPU_X86_MSR_H #define CPU_X86_MSR_H -#include +#include /* IWYU pragma: export */ /* Intel SDM: Table 2-1 * IA-32 architectural MSR: Extended Feature Enable Register diff --git a/src/include/device/mmio.h b/src/include/device/mmio.h index b5b79ee5e690..2b9949e05a2c 100644 --- a/src/include/device/mmio.h +++ b/src/include/device/mmio.h @@ -3,7 +3,7 @@ #ifndef __DEVICE_MMIO_H__ #define __DEVICE_MMIO_H__ -#include +#include /* IWYU pragma: export */ #include #include #include diff --git a/src/include/device/pci.h b/src/include/device/pci.h index f28f319d8cc6..88b955570a69 100644 --- a/src/include/device/pci.h +++ b/src/include/device/pci.h @@ -19,14 +19,15 @@ #if CONFIG(PCI) -#include -#include -#include -#include +/* When is needed, it supposed to provide */ #include +#include /* IWYU pragma: export */ #include #include -#include +#include /* IWYU pragma: export */ +#include +#include +#include /* Common pci operations without a standard interface */ struct pci_operations { diff --git a/src/include/device/pci_ops.h b/src/include/device/pci_ops.h index a1678255c451..b5d4e238aab5 100644 --- a/src/include/device/pci_ops.h +++ b/src/include/device/pci_ops.h @@ -6,7 +6,7 @@ #include #include #include -#include +#include /* IWYU pragma: export */ void __noreturn pcidev_die(void); diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h index e2a6dc23953d..ac23a495012d 100644 --- a/src/include/device/pnp.h +++ b/src/include/device/pnp.h @@ -6,8 +6,8 @@ #include #include /* When is needed, it supposed to provide */ -#include -#include +#include /* IWYU pragma: export */ +#include /* IWYU pragma: export */ #include #if !ENV_PNP_SIMPLE_DEVICE diff --git a/src/include/string.h b/src/include/string.h index f595c7ed2e0d..92ea5e5f7f77 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -3,9 +3,9 @@ #ifndef STRING_H #define STRING_H -#include +#include /* IWYU pragma: export */ #include -#include +#include /* IWYU pragma: export */ void *memcpy(void *dest, const void *src, size_t n); void *memmove(void *dest, const void *src, size_t n); diff --git a/src/include/types.h b/src/include/types.h index 8724d4b01f9b..ca4571777cf0 100644 --- a/src/include/types.h +++ b/src/include/types.h @@ -4,11 +4,13 @@ #define __TYPES_H /* types.h is supposed to provide the standard headers defined in here: */ +/* IWYU pragma: begin_exports */ #include #include #include #include #include +/* IWYU pragma: end_exports */ /* * This may mean something else on architectures where the bits are numbered diff --git a/src/southbridge/intel/bd82x6x/pch.h b/src/southbridge/intel/bd82x6x/pch.h index 15d908ac95a8..34b36c38661a 100644 --- a/src/southbridge/intel/bd82x6x/pch.h +++ b/src/southbridge/intel/bd82x6x/pch.h @@ -22,7 +22,7 @@ #define DEFAULT_GPIOBASE 0x0480 #define DEFAULT_PMBASE 0x0500 -#include +#include /* IWYU pragma: export */ #if CONFIG(SOUTHBRIDGE_INTEL_BD82X6X) #define CROS_GPIO_DEVICE_NAME "CougarPoint" diff --git a/src/southbridge/intel/i82801gx/i82801gx.h b/src/southbridge/intel/i82801gx/i82801gx.h index f2ec1c668d00..68a32dfa55d6 100644 --- a/src/southbridge/intel/i82801gx/i82801gx.h +++ b/src/southbridge/intel/i82801gx/i82801gx.h @@ -7,7 +7,7 @@ #define DEFAULT_GPIOBASE 0x0480 #define DEFAULT_PMBASE 0x0500 -#include +#include /* IWYU pragma: export */ #ifndef __ACPI__ #define DEBUG_PERIODIC_SMIS 0 diff --git a/src/southbridge/intel/i82801ix/i82801ix.h b/src/southbridge/intel/i82801ix/i82801ix.h index 56f14b0d2f33..f0b60f621598 100644 --- a/src/southbridge/intel/i82801ix/i82801ix.h +++ b/src/southbridge/intel/i82801ix/i82801ix.h @@ -5,7 +5,7 @@ #define DEFAULT_TBAR ((u8 *)0xfed1b000) -#include +#include /* IWYU pragma: export */ #if CONFIG(BOARD_EMULATION_QEMU_X86_Q35) /* diff --git a/src/southbridge/intel/i82801jx/i82801jx.h b/src/southbridge/intel/i82801jx/i82801jx.h index 22546897a7d9..33386f5aada4 100644 --- a/src/southbridge/intel/i82801jx/i82801jx.h +++ b/src/southbridge/intel/i82801jx/i82801jx.h @@ -5,7 +5,7 @@ #define DEFAULT_TBAR ((u8 *)0xfed1b000) -#include +#include /* IWYU pragma: export */ #define DEFAULT_PMBASE 0x00000500 #define DEFAULT_TCOBASE (DEFAULT_PMBASE + 0x60) diff --git a/src/southbridge/intel/ibexpeak/pch.h b/src/southbridge/intel/ibexpeak/pch.h index 83e86c266c55..1f5b4ea9a99c 100644 --- a/src/southbridge/intel/ibexpeak/pch.h +++ b/src/southbridge/intel/ibexpeak/pch.h @@ -4,6 +4,7 @@ #define SOUTHBRIDGE_INTEL_BD82X6X_PCH_H #include +#include /* IWYU pragma: export */ /* PCH types */ #define PCH_TYPE_CPT 0x1c /* CougarPoint */ @@ -24,8 +25,6 @@ #define DEFAULT_PMBASE 0x0500 #define DEFAULT_HECIBAR ((u8 *)0xfed17000) -#include - #ifndef __ACPI__ void pch_iobp_update(u32 address, u32 andvalue, u32 orvalue); diff --git a/src/southbridge/intel/lynxpoint/pch.h b/src/southbridge/intel/lynxpoint/pch.h index 7d9fc6d6afd2..1623274633e6 100644 --- a/src/southbridge/intel/lynxpoint/pch.h +++ b/src/southbridge/intel/lynxpoint/pch.h @@ -4,6 +4,7 @@ #define SOUTHBRIDGE_INTEL_LYNXPOINT_PCH_H #include +#include /* IWYU pragma: export */ #define CROS_GPIO_DEVICE_NAME "LynxPoint" @@ -55,8 +56,6 @@ #define DEFAULT_GPIOSIZE 0x80 #endif -#include - #ifndef __ACPI__ #if CONFIG(INTEL_LYNXPOINT_LP) -- cgit v1.2.3