From 39a98260ff1f0e16bdcbe10419b1f2dc4cc170f1 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 12 May 2023 18:51:24 +0200 Subject: soc/amd/*/acpi/mmio.asl,sb_fch.asl: change AAHB's _STA back to method Commit 396fb3db74db ("soc/amd/*/acpi/mmio.asl,sb_fch.asl: hide AAHB device") didn't only change the visibility of the device, but also changed the _STA method to a name. While this worked, the specification says that _STA is supposed to be a method, so change it back to being a method. Signed-off-by: Felix Held Change-Id: Id0932b2875aaf563a4dbd860bdd11a04272e3780 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75169 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/soc/amd/cezanne/acpi/mmio.asl | 5 ++++- src/soc/amd/glinda/acpi/mmio.asl | 5 ++++- src/soc/amd/mendocino/acpi/mmio.asl | 5 ++++- src/soc/amd/phoenix/acpi/mmio.asl | 5 ++++- src/soc/amd/picasso/acpi/sb_fch.asl | 5 ++++- src/soc/amd/stoneyridge/acpi/sb_fch.asl | 5 ++++- 6 files changed, 24 insertions(+), 6 deletions(-) diff --git a/src/soc/amd/cezanne/acpi/mmio.asl b/src/soc/amd/cezanne/acpi/mmio.asl index a109f53ff250..a8508f7df5c8 100644 --- a/src/soc/amd/cezanne/acpi/mmio.asl +++ b/src/soc/amd/cezanne/acpi/mmio.asl @@ -14,7 +14,10 @@ Device (AAHB) { Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) }) - Name (_STA, 0xb) + Method (_STA, 0x0, NotSerialized) + { + Return (0x0b) + } } Device (GPIO) diff --git a/src/soc/amd/glinda/acpi/mmio.asl b/src/soc/amd/glinda/acpi/mmio.asl index 07ff7903d5a9..e3cb7a51ef4c 100644 --- a/src/soc/amd/glinda/acpi/mmio.asl +++ b/src/soc/amd/glinda/acpi/mmio.asl @@ -16,7 +16,10 @@ Device (AAHB) { Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) }) - Name (_STA, 0xb) + Method (_STA, 0x0, NotSerialized) + { + Return (0x0b) + } } Device (GPIO) diff --git a/src/soc/amd/mendocino/acpi/mmio.asl b/src/soc/amd/mendocino/acpi/mmio.asl index c4acfb12db37..cba3ec659976 100644 --- a/src/soc/amd/mendocino/acpi/mmio.asl +++ b/src/soc/amd/mendocino/acpi/mmio.asl @@ -16,7 +16,10 @@ Device (AAHB) { Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) }) - Name (_STA, 0xb) + Method (_STA, 0x0, NotSerialized) + { + Return (0x0b) + } } Device (GPIO) diff --git a/src/soc/amd/phoenix/acpi/mmio.asl b/src/soc/amd/phoenix/acpi/mmio.asl index e8130b0037b3..9d70fd666e87 100644 --- a/src/soc/amd/phoenix/acpi/mmio.asl +++ b/src/soc/amd/phoenix/acpi/mmio.asl @@ -16,7 +16,10 @@ Device (AAHB) { Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) }) - Name (_STA, 0xb) + Method (_STA, 0x0, NotSerialized) + { + Return (0x0b) + } } Device (GPIO) diff --git a/src/soc/amd/picasso/acpi/sb_fch.asl b/src/soc/amd/picasso/acpi/sb_fch.asl index d58e04488213..a0dfd464830d 100644 --- a/src/soc/amd/picasso/acpi/sb_fch.asl +++ b/src/soc/amd/picasso/acpi/sb_fch.asl @@ -14,7 +14,10 @@ Device (AAHB) { Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) }) - Name (_STA, 0xb) + Method (_STA, 0x0, NotSerialized) + { + Return (0x0b) + } } Device (GPIO) diff --git a/src/soc/amd/stoneyridge/acpi/sb_fch.asl b/src/soc/amd/stoneyridge/acpi/sb_fch.asl index d7490d719ee5..6876c2ae3d9b 100644 --- a/src/soc/amd/stoneyridge/acpi/sb_fch.asl +++ b/src/soc/amd/stoneyridge/acpi/sb_fch.asl @@ -12,7 +12,10 @@ Device (AAHB) { Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) }) - Name (_STA, 0xb) + Method (_STA, 0x0, NotSerialized) + { + Return (0x0b) + } } Device (GPIO) -- cgit v1.2.3