From 3f06e6c74089a1dffcf9340890c7b5bb10ea2119 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sun, 18 Feb 2024 12:31:13 -0600 Subject: mb/google/volteer: Disable PM ACPI timer to fix S0i3 regression Keeping the PM timer enabled will disqualify an ADL system from entering S0i3, and will also cause an increase in power during suspend states. The PM timer is not required for brya boards, therefore disabling it. Fixes: 0e90580 (soc/intel: transition full control over PM Timer from FSP to coreboot) This mirrors an identical commit for google/brya: 1ce0f3aab72d ("mb/google/brya: Fix S0i3 regression") TEST=Boot Linux on google/drobit, verify S0i3 counter incrementing after exiting S0ix suspend states. Change-Id: I644e42388c0f6127512bf52e774b79721601ecc9 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/80612 Reviewed-by: Arthur Heymans Reviewed-by: Paul Menzel Reviewed-by: Nico Huber Reviewed-by: Eric Lai Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) --- src/mainboard/google/volteer/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index f4914c723912..bc5ee6c10e42 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -243,4 +243,7 @@ config VARIANT_HAS_MIPI_CAMERA bool default n +config USE_PM_ACPI_TIMER + default n + endif # BOARD_GOOGLE_BASEBOARD_VOLTEER -- cgit v1.2.3