From 4f1ba69b3c0d3ac8501b713642b11c811c09024c Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 20 Feb 2024 09:36:59 -0600 Subject: soc/intel/common/lpc: Skip setting resources for disabled devices If a downstream LPC device (eg, SIO function) is disabled, we shouldn't attempt to open PMIO windows for it, as those functions often have unset IO bases (which default to 0), resulting in false errors like: [ERROR] LPC IO decode base 0! TEST=build/boot purism/librem_cnl (Mini v2), verify no LPC IO errors in cbmem log for disabled SIO functions. Change-Id: I92c79fc01be21466976f3056242f6d1824878eab Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/80646 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik Reviewed-by: Nico Huber --- src/soc/intel/common/block/lpc/lpc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/soc/intel/common/block/lpc/lpc.c b/src/soc/intel/common/block/lpc/lpc.c index dbd982b5937a..b27e09e96e73 100644 --- a/src/soc/intel/common/block/lpc/lpc.c +++ b/src/soc/intel/common/block/lpc/lpc.c @@ -87,6 +87,9 @@ static void pch_lpc_loop_resources(struct device *dev) { struct resource *res; + if (!dev->enabled) + return; + for (res = dev->resource_list; res; res = res->next) { if (res->flags & IORESOURCE_IO) lpc_open_pmio_window(res->base, res->size); -- cgit v1.2.3