From 5b38099abecb7ac09bd2d95c71549c90a076776b Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Sun, 13 Nov 2022 20:37:19 +0100 Subject: Makefile.inc: Remove workaround ACPI warnings No boards now have a missing dependency so remove the workaround. Original-signed-off-by: Arthur Heymans Original-reviewed-on: https://review.coreboot.org/c/coreboot/+/69514 Original-reviewed-by: Nico Huber Original-tested-by: build bot (Jenkins) Original-reviewed-by: Elyes Haouas Original-reviewed-by: Felix Held Cherry-picked-from: 457f77be37e73e6a06f7cc0c16f14bc462b682f9 Change-Id: I787f6aa588175ba620a068918c42edc9d257c3ef Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/70902 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas --- Makefile.inc | 17 ----------------- src/mainboard/acer/g43t-am3/Kconfig | 3 --- src/mainboard/asrock/h81m-hds/Kconfig | 3 --- src/mainboard/asus/h61-series/Kconfig | 3 --- src/mainboard/asus/p5qpl-am/Kconfig | 3 --- src/mainboard/foxconn/d41s/Kconfig | 3 --- src/mainboard/foxconn/g41s-k/Kconfig | 3 --- src/mainboard/gigabyte/ga-d510ud/Kconfig | 3 --- src/mainboard/intel/dcp847ske/Kconfig | 3 --- src/mainboard/intel/dg41wv/Kconfig | 3 --- src/mainboard/intel/dg43gt/Kconfig | 3 --- src/mainboard/intel/emeraldlake2/Kconfig | 3 --- src/mainboard/supermicro/x10slm-f/Kconfig | 3 --- src/mainboard/supermicro/x9scl/Kconfig | 3 --- 14 files changed, 56 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index 0ed205fb4199..15d824fc0b06 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -265,26 +265,9 @@ endef # ResourceTemplate is the correct code. # As it's valid ASL, disable the warning. EMPTY_RESOURCE_TEMPLATE_WARNING = 3150 -# IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects: -# 1) If _PRS is present, must have _CRS and _SRS -# 2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS) -# 3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS) -# 4) If _SRS is present, probably should have a _DIS (Remark only) -# A warning will be issued for each of these cases. -# For existing ASL code, ignore this warnings -IASL_MISSING_DEPENDENCY = 3141 IASL_WARNINGS_LIST = $(EMPTY_RESOURCE_TEMPLATE_WARNING) -ifeq ($(CONFIG_IGNORE_IASL_MISSING_DEPENDENCY),y) - IASL_WARNINGS_LIST += $(IASL_MISSING_DEPENDENCY) -build_complete:: - printf "*** WARNING: The ASL code for this platform is incomplete. Please fix it. ***\n" - printf "*** If _PRS is present, must have _CRS and _SRS ***\n" - printf "*** If _SRS is present, must have _PRS and _CRS ***\n" - printf "*** If _DIS is present, must have _SRS, _PRS and _CRS ***\n" -endif - IGNORED_IASL_WARNINGS = $(addprefix -vw , $(IASL_WARNINGS_LIST)) define asl_template diff --git a/src/mainboard/acer/g43t-am3/Kconfig b/src/mainboard/acer/g43t-am3/Kconfig index dd2bf3f9f48e..1d4fd53f97d4 100644 --- a/src/mainboard/acer/g43t-am3/Kconfig +++ b/src/mainboard/acer/g43t-am3/Kconfig @@ -2,9 +2,6 @@ if BOARD_ACER_G43T_AM3 -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/asrock/h81m-hds/Kconfig b/src/mainboard/asrock/h81m-hds/Kconfig index 4b21ec58913a..4edd2bc387f3 100644 --- a/src/mainboard/asrock/h81m-hds/Kconfig +++ b/src/mainboard/asrock/h81m-hds/Kconfig @@ -2,9 +2,6 @@ if BOARD_ASROCK_H81M_HDS -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_4096 diff --git a/src/mainboard/asus/h61-series/Kconfig b/src/mainboard/asus/h61-series/Kconfig index 48e4220e7891..eeec4e788207 100644 --- a/src/mainboard/asus/h61-series/Kconfig +++ b/src/mainboard/asus/h61-series/Kconfig @@ -14,9 +14,6 @@ config BOARD_ASUS_H61_SERIES if BOARD_ASUS_H61_SERIES -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config MAINBOARD_DIR default "asus/h61-series" diff --git a/src/mainboard/asus/p5qpl-am/Kconfig b/src/mainboard/asus/p5qpl-am/Kconfig index 100f5918e74e..2359e324d8cb 100644 --- a/src/mainboard/asus/p5qpl-am/Kconfig +++ b/src/mainboard/asus/p5qpl-am/Kconfig @@ -2,9 +2,6 @@ if BOARD_ASUS_P5QPL_AM || BOARD_ASUS_P5G41T_M_LX -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/foxconn/d41s/Kconfig b/src/mainboard/foxconn/d41s/Kconfig index 33d5e6da2aca..6ddc7dffc1cc 100644 --- a/src/mainboard/foxconn/d41s/Kconfig +++ b/src/mainboard/foxconn/d41s/Kconfig @@ -2,9 +2,6 @@ if BOARD_FOXCONN_D41S -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_FCBGA559 diff --git a/src/mainboard/foxconn/g41s-k/Kconfig b/src/mainboard/foxconn/g41s-k/Kconfig index a98a47a77657..b2237599a4b1 100644 --- a/src/mainboard/foxconn/g41s-k/Kconfig +++ b/src/mainboard/foxconn/g41s-k/Kconfig @@ -2,9 +2,6 @@ if BOARD_FOXCONN_G41S_K || BOARD_FOXCONN_G41M -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/gigabyte/ga-d510ud/Kconfig b/src/mainboard/gigabyte/ga-d510ud/Kconfig index 4739f81b03f6..731b9f40eee4 100644 --- a/src/mainboard/gigabyte/ga-d510ud/Kconfig +++ b/src/mainboard/gigabyte/ga-d510ud/Kconfig @@ -2,9 +2,6 @@ if BOARD_GIGABYTE_GA_D510UD -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_512 diff --git a/src/mainboard/intel/dcp847ske/Kconfig b/src/mainboard/intel/dcp847ske/Kconfig index c5e5afde2864..ebc172b6b093 100644 --- a/src/mainboard/intel/dcp847ske/Kconfig +++ b/src/mainboard/intel/dcp847ske/Kconfig @@ -1,8 +1,5 @@ if BOARD_INTEL_DCP847SKE -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 diff --git a/src/mainboard/intel/dg41wv/Kconfig b/src/mainboard/intel/dg41wv/Kconfig index 8c5a5d61114a..bb201bc76d29 100644 --- a/src/mainboard/intel/dg41wv/Kconfig +++ b/src/mainboard/intel/dg41wv/Kconfig @@ -2,9 +2,6 @@ if BOARD_INTEL_DG41WV -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/intel/dg43gt/Kconfig b/src/mainboard/intel/dg43gt/Kconfig index 55b5cd08f0fe..c3c853cdeb7c 100644 --- a/src/mainboard/intel/dg43gt/Kconfig +++ b/src/mainboard/intel/dg43gt/Kconfig @@ -2,9 +2,6 @@ if BOARD_INTEL_DG43GT -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_SOCKET_LGA775 diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig index 0220d73c221f..86fe98a803ad 100644 --- a/src/mainboard/intel/emeraldlake2/Kconfig +++ b/src/mainboard/intel/emeraldlake2/Kconfig @@ -1,8 +1,5 @@ if BOARD_INTEL_EMERALDLAKE2 -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select NORTHBRIDGE_INTEL_SANDYBRIDGE diff --git a/src/mainboard/supermicro/x10slm-f/Kconfig b/src/mainboard/supermicro/x10slm-f/Kconfig index 24e67c7682f9..28c7c1a20fec 100644 --- a/src/mainboard/supermicro/x10slm-f/Kconfig +++ b/src/mainboard/supermicro/x10slm-f/Kconfig @@ -2,9 +2,6 @@ if BOARD_SUPERMICRO_X10SLM_PLUS_F -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_16384 diff --git a/src/mainboard/supermicro/x9scl/Kconfig b/src/mainboard/supermicro/x9scl/Kconfig index 469b7916a7f9..40b42137b2a0 100644 --- a/src/mainboard/supermicro/x9scl/Kconfig +++ b/src/mainboard/supermicro/x9scl/Kconfig @@ -1,8 +1,5 @@ if BOARD_SUPERMICRO_X9SCL -config IGNORE_IASL_MISSING_DEPENDENCY - def_bool y - config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 -- cgit v1.2.3