From abbfa555b02aa7c905f8cca27a22000c3bd7e47c Mon Sep 17 00:00:00 2001 From: Reka Norman Date: Wed, 3 Aug 2022 10:22:32 +1000 Subject: commonlib/timestamp_serialized: Add comment explaining "ignore for x86" BUG=b:240624460 TEST=None Signed-off-by: Reka Norman Change-Id: I8542c9bb624a366bc1bb01f6eae66ba97520d19c Reviewed-on: https://review.coreboot.org/c/coreboot/+/66381 Reviewed-by: Julius Werner Tested-by: build bot (Jenkins) --- src/commonlib/include/commonlib/timestamp_serialized.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/commonlib/include/commonlib/timestamp_serialized.h b/src/commonlib/include/commonlib/timestamp_serialized.h index bc2152eab438..4b1001ef3927 100644 --- a/src/commonlib/include/commonlib/timestamp_serialized.h +++ b/src/commonlib/include/commonlib/timestamp_serialized.h @@ -199,6 +199,14 @@ static const struct timestamp_id_to_name { TS_NAME_DEF(TS_BOOTBLOCK_END, 0, "end of bootblock"), TS_NAME_DEF(TS_COPYROM_START, TS_COPYROM_END, "starting to load romstage"), TS_NAME_DEF(TS_COPYROM_END, 0, "finished loading romstage"), + /* + * "ignore for x86": On platforms with memory-mapped flash, it's + * impossible to separate loading times from decompression times because + * the flash accesses happen in the background as the decompression is + * running. So it makes more sense to consider the total loading + + * decompression time by looking at the timestamps before and after the + * decompression timestamps. + */ TS_NAME_DEF(TS_ULZMA_START, TS_ULZMA_END, "starting LZMA decompress (ignore for x86)"), TS_NAME_DEF(TS_ULZMA_END, 0, "finished LZMA decompress (ignore for x86)"), TS_NAME_DEF(TS_ULZ4F_START, TS_ULZ4F_END, "starting LZ4 decompress (ignore for x86)"), -- cgit v1.2.3