From d5ef6be38e196e370212c586dd243d36aa2f81f8 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Sun, 13 Nov 2022 20:33:23 +0100 Subject: {ec/superio}/acpi: Remove _PRS if no _SRS is implemented _PRS only makes sense if _SRS is implemented. Original-signed-off-by: Arthur Heymans Original-reviewed-on: https://review.coreboot.org/c/coreboot/+/69513 Original-reviewed-by: Elyes Haouas Original-tested-by: build bot (Jenkins) Original-reviewed-by: Martin Roth Cherry-picked-from: 87d4f114a24d713c7ce965a52b83974f7b089557 Change-Id: I030bd716215b5ac5738e00ebf6ed991d9d6c5ca0 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/70901 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas --- src/ec/google/wilco/acpi/ec_dev.asl | 19 ------------- src/ec/google/wilco/acpi/superio.asl | 27 ------------------ src/ec/quanta/ene_kb3940q/acpi/superio.asl | 10 ------- src/ec/quanta/it8518/acpi/superio.asl | 22 --------------- src/superio/ite/it8772f/acpi/superio.asl | 39 -------------------------- src/superio/smsc/sio1007/acpi/superio.asl | 44 ------------------------------ 6 files changed, 161 deletions(-) diff --git a/src/ec/google/wilco/acpi/ec_dev.asl b/src/ec/google/wilco/acpi/ec_dev.asl index 5c88d669bc28..d8192d1d4270 100644 --- a/src/ec/google/wilco/acpi/ec_dev.asl +++ b/src/ec/google/wilco/acpi/ec_dev.asl @@ -29,25 +29,6 @@ Device (WLCO) CONFIG_EC_BASE_PACKET, 16, 16) }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, - CONFIG_EC_BASE_HOST_DATA, - CONFIG_EC_BASE_HOST_DATA, - 4, 4) - IO (Decode16, - CONFIG_EC_BASE_HOST_COMMAND, - CONFIG_EC_BASE_HOST_COMMAND, - 4, 4) - IO (Decode16, - CONFIG_EC_BASE_PACKET, - CONFIG_EC_BASE_PACKET, - 16, 16) - } - EndDependentFn () - }) } Device (WEVT) diff --git a/src/ec/google/wilco/acpi/superio.asl b/src/ec/google/wilco/acpi/superio.asl index a779147abb38..7edc9fe208c1 100644 --- a/src/ec/google/wilco/acpi/superio.asl +++ b/src/ec/google/wilco/acpi/superio.asl @@ -26,15 +26,6 @@ Device (SIO) IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - StartDependentFn (0, 0) { - IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08) - IRQNoFlags () {4} - } - EndDependentFn () - }) } Device (PS2K) @@ -58,16 +49,6 @@ Device (SIO) IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQ (Edge, ActiveHigh, Exclusive) {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQ (Edge, ActiveHigh, Exclusive) {1} - } - EndDependentFn () - }) } Device (PS2M) @@ -88,13 +69,5 @@ Device (SIO) { IRQ (Edge, ActiveHigh, Exclusive) {12} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - IRQ (Edge, ActiveHigh, Exclusive) {12} - } - EndDependentFn () - }) } } diff --git a/src/ec/quanta/ene_kb3940q/acpi/superio.asl b/src/ec/quanta/ene_kb3940q/acpi/superio.asl index 008f573f759f..b5962f02670d 100644 --- a/src/ec/quanta/ene_kb3940q/acpi/superio.asl +++ b/src/ec/quanta/ene_kb3940q/acpi/superio.asl @@ -24,16 +24,6 @@ Device (SIO) { FixedIO (0x64, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {1} - } - EndDependentFn () - }) } #endif } diff --git a/src/ec/quanta/it8518/acpi/superio.asl b/src/ec/quanta/it8518/acpi/superio.asl index 9cdf26581af5..b91324ded34f 100644 --- a/src/ec/quanta/it8518/acpi/superio.asl +++ b/src/ec/quanta/it8518/acpi/superio.asl @@ -25,17 +25,6 @@ Device (SIO) FixedIO (0x64, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) - { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {1} - } - EndDependentFn () - }) } #endif @@ -55,17 +44,6 @@ Device (SIO) FixedIO (0x64, 0x01) IRQNoFlags () {12} }) - - Name (_PRS, ResourceTemplate() - { - StartDependentFn (0, 0) - { - FixedIO (0x60, 0x01) - FixedIO (0x64, 0x01) - IRQNoFlags () {12} - } - EndDependentFn () - }) } #endif diff --git a/src/superio/ite/it8772f/acpi/superio.asl b/src/superio/ite/it8772f/acpi/superio.asl index 5132df076279..809d0fcea6a8 100644 --- a/src/superio/ite/it8772f/acpi/superio.asl +++ b/src/superio/ite/it8772f/acpi/superio.asl @@ -108,12 +108,6 @@ Device (SIO) { IO (Decode16, SIO_ENVC_IO1, SIO_ENVC_IO1, 0x04, 0x04) }) - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_ENVC_IO0, SIO_ENVC_IO0, 0x08, 0x08) - IO (Decode16, SIO_ENVC_IO1, SIO_ENVC_IO1, 0x04, 0x04) - }) - OperationRegion (ECAP, SystemIO, SIO_ENVC_IO0, 0x07) Field (ECAP, ByteAcc, NoLock, Preserve) { @@ -151,12 +145,6 @@ Device (SIO) { IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) - IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) - }) } #endif @@ -175,11 +163,6 @@ Device (SIO) { IRQNoFlags () {4} }) - Name (_PRS, ResourceTemplate () - { - IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) - IRQNoFlags () {4} - }) } #endif @@ -200,12 +183,6 @@ Device (SIO) { IRQNoFlags () {1} }) - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif @@ -223,10 +200,6 @@ Device (SIO) { IRQNoFlags () {12} }) - Name (_PRS, ResourceTemplate() - { - IRQNoFlags () {12} - }) } #endif @@ -247,13 +220,6 @@ Device (SIO) { DMA (Compatibility, NotBusMaster, Transfer8) {2} }) - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) - IRQNoFlags () {6} - DMA (Compatibility, NotBusMaster, Transfer8) {2} - }) } #endif @@ -272,11 +238,6 @@ Device (SIO) { IRQNoFlags () { SIO_INFR_IRQ } }) - Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) - IRQNoFlags () { SIO_INFR_IRQ } - }) } #endif } diff --git a/src/superio/smsc/sio1007/acpi/superio.asl b/src/superio/smsc/sio1007/acpi/superio.asl index 5132df076279..35d9ba1cfc93 100644 --- a/src/superio/smsc/sio1007/acpi/superio.asl +++ b/src/superio/smsc/sio1007/acpi/superio.asl @@ -108,12 +108,6 @@ Device (SIO) { IO (Decode16, SIO_ENVC_IO1, SIO_ENVC_IO1, 0x04, 0x04) }) - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_ENVC_IO0, SIO_ENVC_IO0, 0x08, 0x08) - IO (Decode16, SIO_ENVC_IO1, SIO_ENVC_IO1, 0x04, 0x04) - }) - OperationRegion (ECAP, SystemIO, SIO_ENVC_IO0, 0x07) Field (ECAP, ByteAcc, NoLock, Preserve) { @@ -151,12 +145,6 @@ Device (SIO) { IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, SIO_GPIO_IO0, SIO_GPIO_IO0, 0x01, 0x01) - IO (Decode16, SIO_GPIO_IO1, SIO_GPIO_IO1, 0x08, 0x08) - }) } #endif @@ -174,12 +162,6 @@ Device (SIO) { IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) IRQNoFlags () {4} }) - - Name (_PRS, ResourceTemplate () - { - IO (Decode16, 0x03F8, 0x03F8, 0x08, 0x08) - IRQNoFlags () {4} - }) } #endif @@ -199,13 +181,6 @@ Device (SIO) { IO (Decode16, 0x64, 0x64, 0x01, 0x01) IRQNoFlags () {1} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x60, 0x60, 0x01, 0x01) - IO (Decode16, 0x64, 0x64, 0x01, 0x01) - IRQNoFlags () {1} - }) } #endif @@ -222,11 +197,6 @@ Device (SIO) { { IRQNoFlags () {12} }) - - Name (_PRS, ResourceTemplate() - { - IRQNoFlags () {12} - }) } #endif @@ -246,14 +216,6 @@ Device (SIO) { IRQNoFlags () {6} DMA (Compatibility, NotBusMaster, Transfer8) {2} }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, 0x03F0, 0x03F0, 0x01, 0x06) - IO (Decode16, 0x03F7, 0x03F7, 0x01, 0x01) - IRQNoFlags () {6} - DMA (Compatibility, NotBusMaster, Transfer8) {2} - }) } #endif @@ -271,12 +233,6 @@ Device (SIO) { IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) IRQNoFlags () { SIO_INFR_IRQ } }) - - Name (_PRS, ResourceTemplate() - { - IO (Decode16, SIO_INFR_IO0, SIO_INFR_IO0, 0x08, 0x08) - IRQNoFlags () { SIO_INFR_IRQ } - }) } #endif } -- cgit v1.2.3