From f1ad184bb70bcb132383431bdfe5dca4683695a3 Mon Sep 17 00:00:00 2001 From: Myles Watson Date: Wed, 7 Jan 2009 18:37:21 +0000 Subject: This trivial patch adds the warnings Peter and Ron requested to the ck804 code. Signed-off-by: Myles Watson Acked-by: Myles Watson git-svn-id: svn://coreboot.org/repository/coreboot-v3@1104 f3766cd6-281f-0410-b1cd-43a5c92072e9 --- southbridge/nvidia/ck804/ck804_nic.c | 2 ++ southbridge/nvidia/ck804/lpc.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/southbridge/nvidia/ck804/ck804_nic.c b/southbridge/nvidia/ck804/ck804_nic.c index 4b6b6804d1ea..a5bc5ddac50e 100644 --- a/southbridge/nvidia/ck804/ck804_nic.c +++ b/southbridge/nvidia/ck804/ck804_nic.c @@ -89,6 +89,8 @@ static void nic_init(struct device *dev) } } +#warning This should be fixed. Can we use a LAR file for the MAC? + /* If that is invalid we will read that from romstrap. */ if (!eeprom_valid) { unsigned long mac_pos; diff --git a/southbridge/nvidia/ck804/lpc.c b/southbridge/nvidia/ck804/lpc.c index f7d962c9fe83..79a41f1a1ff1 100644 --- a/southbridge/nvidia/ck804/lpc.c +++ b/southbridge/nvidia/ck804/lpc.c @@ -124,6 +124,8 @@ static void setup_ioapic(unsigned long ioapic_base) #define SLOW_CPU_OFF 0 #define SLOW_CPU__ON 1 +#warning Power on after fail should be a CMOS option. + #ifndef MAINBOARD_POWER_ON_AFTER_POWER_FAIL #define MAINBOARD_POWER_ON_AFTER_POWER_FAIL MAINBOARD_POWER_ON #endif -- cgit v1.2.3