From b50602007656962ab6717d63d2f9d83e5c00dacf Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Tue, 6 Feb 2024 22:38:14 -0800 Subject: commonlib: Change GCD function to always use 64 bits It seems that we have some applications where we need to calculate a GCD in 64 bits. Now, we could instantiate the algorithm multiple times for different bit width combinations to be able to use the most efficient one for each problem... but considering that the function usually only gets called once per callsite per stage, and that software emulation of 64-bit division on 32-bit systems doesn't take *that* long either, we would probably usually be paying more time loading the second instance of the function than we save with faster divisions. So let's just make things easy and always do it in 64-bit and then nobody has to spend time thinking on which version to call. Change-Id: I028361444c4048a0d76ba4f80c7334a9d9983c87 Signed-off-by: Julius Werner Reviewed-on: https://review.coreboot.org/c/coreboot/+/80319 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) Reviewed-by: Yidi Lin --- payloads/libpayload/libc/getopt_long.c | 2 +- payloads/libpayload/libc/time.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'payloads') diff --git a/payloads/libpayload/libc/getopt_long.c b/payloads/libpayload/libc/getopt_long.c index 822ce96904cf..c0303cfea3f9 100644 --- a/payloads/libpayload/libc/getopt_long.c +++ b/payloads/libpayload/libc/getopt_long.c @@ -122,7 +122,7 @@ permute_args(int panonopt_start, int panonopt_end, int opt_end, */ nnonopts = panonopt_end - panonopt_start; nopts = opt_end - panonopt_end; - ncycle = gcd32(nnonopts, nopts); + ncycle = gcd(nnonopts, nopts); cyclelen = (opt_end - panonopt_start) / ncycle; for (i = 0; i < ncycle; i++) { diff --git a/payloads/libpayload/libc/time.c b/payloads/libpayload/libc/time.c index c38dbfdde8a5..28f2b3e2a959 100644 --- a/payloads/libpayload/libc/time.c +++ b/payloads/libpayload/libc/time.c @@ -182,7 +182,7 @@ u64 timer_us(u64 base) "must be at least 1MHz.\n", hz); halt(); } - div = gcd32(hz, mult); + div = gcd(hz, mult); hz /= div; mult /= div; } -- cgit v1.2.3