From d2cdfff63b6e2376fad729252a57acfd2b4418ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Tue, 5 Mar 2019 07:56:38 +0200 Subject: device/pci: Rewrite PCI MMCONF with symbol reference MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The effect of pointer aliasing on writes is that any data on CPU registers that has been resolved from (non-const and non-volatile) memory objects has to be discarded and resolved. In other words, the compiler assumes that a pointer that does not have an absolute value at build-time, and is of type 'void *' or 'char *', may write over any memory object. Using a unique datatype for MMIO writes makes the pointer to _not_ qualify for pointer aliasing with any other objects in memory. This avoid constantly resolving the PCI MMCONF address, which is a derived value from a 'struct device *'. Change-Id: Id112aa5e729ffd8015bb806786bdee38783b7ea9 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/31752 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/device/Makefile.inc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'src/device/Makefile.inc') diff --git a/src/device/Makefile.inc b/src/device/Makefile.inc index 711a4033532b..baa45bec3e6a 100644 --- a/src/device/Makefile.inc +++ b/src/device/Makefile.inc @@ -26,9 +26,15 @@ postcar-y += pci_early.c ramstage-y += pci_class.c ramstage-y += pci_device.c -ramstage-y += pci_ops.c ramstage-y += pci_rom.c +bootblock-y += pci_ops.c +verstage-y += pci_ops.c +romstage-y += pci_ops.c +postcar-y += pci_ops.c +ramstage-y += pci_ops.c +smm-y += pci_ops.c + ramstage-$(CONFIG_HYPERTRANSPORT_PLUGIN_SUPPORT) += hypertransport.c ramstage-$(CONFIG_PCIX_PLUGIN_SUPPORT) += pcix_device.c ramstage-$(CONFIG_PCIEXP_PLUGIN_SUPPORT) += pciexp_device.c -- cgit v1.2.3