From a3b29d7bd0ed2b30824ef8babe03aaea85294f05 Mon Sep 17 00:00:00 2001 From: Jan Samek Date: Tue, 31 Jan 2023 14:09:30 +0100 Subject: drv/i2c/ptn3460: Add 'mainboard' prefix to mainboard-level callbacks As discused earlier, the callback name 'mb_adjust_cfg' was considered too generic. The new naming is chosen to be consistent with other drivers' callback names designed to be used at mainboard level. Also other functions, namely 'mb_get_edid' and 'mb_select_edid_table' are renamed accordingly. BUG=none TEST=Builds for siemens/mc_apl{1,4,5,7} and siemens/mc_ehl boards complete successfully. Change-Id: I4cbec0e72e5f03e94df0faa36765d1a6cd873a7a Signed-off-by: Jan Samek Reviewed-on: https://review.coreboot.org/c/coreboot/+/72629 Tested-by: build bot (Jenkins) Reviewed-by: Mario Scheithauer Reviewed-by: Werner Zeh --- src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c | 6 +++--- src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c | 6 +++--- src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c | 6 +++--- src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c | 6 +++--- src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c | 6 +++--- 5 files changed, 15 insertions(+), 15 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c index 8a20f364d5d0..bad4da79ea69 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) +enum cb_err mainboard_ptn3460_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; @@ -31,7 +31,7 @@ enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) * which has to be used. * @return Index of the EDID slot selected for EDID emulation */ -uint8_t mb_select_edid_table(void) +uint8_t mainboard_ptn3460_select_edid_table(void) { return 6; /* With this mainboard we use EDID block 6 for emulation in PTN3460. */ } @@ -41,7 +41,7 @@ uint8_t mb_select_edid_table(void) * @param *cfg_ptr Pointer to the PTN config structure to modify * @return CB_SUCCESS if data was modified and needs to be updated; CB_ERR on error */ -enum cb_err mb_adjust_cfg(struct ptn_3460_config *cfg) +enum cb_err mainboard_ptn3460_config(struct ptn_3460_config *cfg) { const char *hwi_block = "hwinfo.hex"; uint8_t disp_con = 0, color_depth = 0; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c index 39cc274e2129..7f4334eb9e34 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) +enum cb_err mainboard_ptn3460_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; @@ -31,7 +31,7 @@ enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) * which has to be used. * @return Index of the EDID slot selected for EDID emulation */ -uint8_t mb_select_edid_table(void) +uint8_t mainboard_ptn3460_select_edid_table(void) { return 6; /* With this mainboard we use EDID block 6 for emulation in PTN3460. */ } @@ -41,7 +41,7 @@ uint8_t mb_select_edid_table(void) * @param *cfg_ptr Pointer to the PTN config structure to modify * @return CB_SUCCESS if data was modified and needs to be updated; CB_ERR on error */ -enum cb_err mb_adjust_cfg(struct ptn_3460_config *cfg) +enum cb_err mainboard_ptn3460_config(struct ptn_3460_config *cfg) { const char *hwi_block = "hwinfo.hex"; uint8_t disp_con = 0, color_depth = 0; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c index c74e90ab6125..320fcc7f47ab 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/lcd_panel.c @@ -33,7 +33,7 @@ static void igd_disable(void) * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) +enum cb_err mainboard_ptn3460_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; @@ -56,7 +56,7 @@ enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) * which has to be used. * @return Index of the EDID slot selected for EDID emulation */ -uint8_t mb_select_edid_table(void) +uint8_t mainboard_ptn3460_select_edid_table(void) { return 6; /* With this mainboard we use EDID block 6 for emulation in PTN3460. */ } @@ -66,7 +66,7 @@ uint8_t mb_select_edid_table(void) * @param *cfg_ptr Pointer to the PTN config structure to modify * @return CB_SUCCESS if data was modified and needs to be updated; CB_ERR on error */ -enum cb_err mb_adjust_cfg(struct ptn_3460_config *cfg) +enum cb_err mainboard_ptn3460_config(struct ptn_3460_config *cfg) { const char *hwi_block = "hwinfo.hex"; uint8_t disp_con = 0, color_depth = 0; diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c index 39cc274e2129..7f4334eb9e34 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl7/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) +enum cb_err mainboard_ptn3460_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; @@ -31,7 +31,7 @@ enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) * which has to be used. * @return Index of the EDID slot selected for EDID emulation */ -uint8_t mb_select_edid_table(void) +uint8_t mainboard_ptn3460_select_edid_table(void) { return 6; /* With this mainboard we use EDID block 6 for emulation in PTN3460. */ } @@ -41,7 +41,7 @@ uint8_t mb_select_edid_table(void) * @param *cfg_ptr Pointer to the PTN config structure to modify * @return CB_SUCCESS if data was modified and needs to be updated; CB_ERR on error */ -enum cb_err mb_adjust_cfg(struct ptn_3460_config *cfg) +enum cb_err mainboard_ptn3460_config(struct ptn_3460_config *cfg) { const char *hwi_block = "hwinfo.hex"; uint8_t disp_con = 0, color_depth = 0; diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c index 965f62d57d37..a4985c1c216c 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl3/lcd_panel.c @@ -10,7 +10,7 @@ * @param edid_data pointer to EDID data in driver * @return CB_SUCCESS on successful EDID data retrieval, CB_ERR otherwise */ -enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) +enum cb_err mainboard_ptn3460_get_edid(uint8_t edid_data[PTN_EDID_LEN]) { const char *hwi_block = "hwinfo.hex"; @@ -31,7 +31,7 @@ enum cb_err mb_get_edid(uint8_t edid_data[PTN_EDID_LEN]) * which has to be used. * @return Index of the EDID slot selected for EDID emulation */ -uint8_t mb_select_edid_table(void) +uint8_t mainboard_ptn3460_select_edid_table(void) { return 6; /* With this mainboard we use EDID block 6 for emulation in PTN3460. */ } @@ -41,7 +41,7 @@ uint8_t mb_select_edid_table(void) * @param *cfg_ptr Pointer to the PTN config structure to modify * @return CB_SUCCESS if data was modified and needs to be updated; CB_ERR on error */ -enum cb_err mb_adjust_cfg(struct ptn_3460_config *cfg) +enum cb_err mainboard_ptn3460_config(struct ptn_3460_config *cfg) { const char *hwi_block = "hwinfo.hex"; uint8_t disp_con = 0, color_depth = 0; -- cgit v1.2.3