From ac08e8fa8c86dca9de732f8d8913ba1b8062b1c3 Mon Sep 17 00:00:00 2001 From: Meera Ravindranath Date: Thu, 6 Oct 2022 14:24:07 +0530 Subject: mb/google/brya/nivviks: Enable ISH driver and firmware name BRANCH=none BUG=b:234776154 TEST=build and boot Nirwen UFS, copy ISH firmware to host file system /lib/firmware/intel/adln_ish.bin check "dmesg |grep ish", it should show: ish-loader: ISH firmware intel/adlnrvp_ish.bin loaded Signed-off-by: Meera Ravindranath Change-Id: I89782b0b7dde1fca0130472a38628e72dfd5c26c Reviewed-on: https://review.coreboot.org/c/coreboot/+/68164 Tested-by: build bot (Jenkins) Reviewed-by: Reka Norman --- src/drivers/intel/ish/ish.c | 1 + src/include/device/pci_ids.h | 1 + src/mainboard/google/brya/Kconfig | 1 + src/mainboard/google/brya/variants/nivviks/overridetree.cb | 4 ++++ 4 files changed, 7 insertions(+) (limited to 'src') diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c index 78e2f6c7438d..2403333be13f 100644 --- a/src/drivers/intel/ish/ish.c +++ b/src/drivers/intel/ish/ish.c @@ -56,6 +56,7 @@ static const unsigned short pci_device_ids[] = { PCI_DID_INTEL_CML_ISHB, PCI_DID_INTEL_TGL_ISHB, PCI_DID_INTEL_TGL_H_ISHB, + PCI_DID_INTEL_ADL_N_ISHB, 0 }; diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 3da741001659..4301cfb76dde 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2182,6 +2182,7 @@ #define PCI_DID_INTEL_TGL_ISHB 0xa0fc #define PCI_DID_INTEL_TGL_H_ISHB 0x43fc #define PCI_DID_INTEL_MTL_ISHB 0x7e45 +#define PCI_DID_INTEL_ADL_N_ISHB 0x54fc /* Intel 82371FB (PIIX) */ #define PCI_DID_INTEL_82371FB_ISA 0x122e diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index dbf6a020916e..f34243203d4d 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -65,6 +65,7 @@ config BOARD_GOOGLE_BASEBOARD_NISSA select BOARD_GOOGLE_BRYA_COMMON select BOARD_ROMSIZE_KB_16384 if !BOARD_ROMSIZE_KB_32768 select CHROMEOS_DRAM_PART_NUMBER_IN_CBI if CHROMEOS + select DRIVERS_INTEL_ISH select MEMORY_SOLDERDOWN select SOC_INTEL_ALDERLAKE_PCH_N select SOC_INTEL_CSE_LITE_COMPRESS_ME_RW diff --git a/src/mainboard/google/brya/variants/nivviks/overridetree.cb b/src/mainboard/google/brya/variants/nivviks/overridetree.cb index 76fe43e71cf4..fc20c0933956 100644 --- a/src/mainboard/google/brya/variants/nivviks/overridetree.cb +++ b/src/mainboard/google/brya/variants/nivviks/overridetree.cb @@ -519,6 +519,10 @@ chip soc/intel/alderlake probe STORAGE STORAGE_EMMC end device ref ish on + chip drivers/intel/ish + register "firmware_name" = ""adln_ish.bin"" + device generic 0 on end + end probe STORAGE STORAGE_UFS end device ref ufs on -- cgit v1.2.3