From b0f52fb5bfa71d2ddf5741408cc14fcfdf8f5ffc Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 1 Mar 2021 18:11:13 +0100 Subject: soc/intel/cannonlake: Move `gpi_clear_int_cfg()` call To allow unifying bootblock.c in follow-ups, move a function call. Change-Id: I0f40ee7fd47f7f9f582f314dfcd1b4b93b1db791 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/51148 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak Reviewed-by: Furquan Shaikh --- src/soc/intel/cannonlake/bootblock/bootblock.c | 5 ----- src/soc/intel/cannonlake/bootblock/pch.c | 7 +++++++ 2 files changed, 7 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/soc/intel/cannonlake/bootblock/bootblock.c b/src/soc/intel/cannonlake/bootblock/bootblock.c index dfa0bd00b5f4..1354c43a22e4 100644 --- a/src/soc/intel/cannonlake/bootblock/bootblock.c +++ b/src/soc/intel/cannonlake/bootblock/bootblock.c @@ -61,11 +61,6 @@ void bootblock_soc_early_init(void) void bootblock_soc_init(void) { - /* - * Clear the GPI interrupt status and enable registers. These - * registers do not get reset to default state when booting from S5. - */ - gpi_clear_int_cfg(); report_platform_info(); bootblock_pch_init(); diff --git a/src/soc/intel/cannonlake/bootblock/pch.c b/src/soc/intel/cannonlake/bootblock/pch.c index 51f8fb59f673..a4f47c990b4e 100644 --- a/src/soc/intel/cannonlake/bootblock/pch.c +++ b/src/soc/intel/cannonlake/bootblock/pch.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -131,6 +132,12 @@ void pch_early_iorange_init(void) void bootblock_pch_init(void) { + /* + * Clear the GPI interrupt status and enable registers. These + * registers do not get reset to default state when booting from S5. + */ + gpi_clear_int_cfg(); + /* * Enabling ABASE for accessing PM1_STS, PM1_EN, PM1_CNT, * GPE0_STS, GPE0_EN registers. -- cgit v1.2.3