From 967f862e47e26cd07b6b43eda6e1445f58e8989b Mon Sep 17 00:00:00 2001
From: Jacob Garber <jgarber1@ualberta.ca>
Date: Tue, 2 Jul 2019 10:35:10 -0600
Subject: util/amdfwtool: Close file descriptor on error

Prevents a resource leak.

Change-Id: Id5da2df3e37cba499cd2e9a7c3ede34e4de2ed77
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1402139
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33961
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
---
 util/amdfwtool/amdfwtool.c | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'util/amdfwtool/amdfwtool.c')

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index 37dbcd093fb0..e8ac0b1ae95c 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -566,11 +566,13 @@ static ssize_t copy_blob(void *dest, const char *src_file, size_t room)
 
 	if (fstat(fd, &fd_stat)) {
 		printf("fstat error: %s\n", strerror(errno));
+		close(fd);
 		return -2;
 	}
 
 	if (fd_stat.st_size > room) {
 		printf("Error: %s will not fit.  Exiting.\n", src_file);
+		close(fd);
 		return -3;
 	}
 
-- 
cgit v1.2.3