From 7ccb2821d27624d97e9728629bf675242d4966d8 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Sun, 16 Dec 2018 22:38:58 +0100 Subject: util/board_status.sh: Fix command for fetching the kernel log 94b761c8e (util/board_status: run dmesg with sudo) attempted to fetch the console as root locally but instead sudo was put in front of the remote path which runs as root anyways. Also unless quotation marks are used the cmd function will see 'sudo' and 'dmesg' as separate aruguments. Change-Id: Ib9e9e4b443f4e3ad04c5fda2c2ce626255a190f2 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/30264 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/board_status/board_status.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'util/board_status') diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index bba3d1f6b10b..0dc96e8bd79f 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -381,7 +381,7 @@ elif [ -n "$REMOTE_HOST" ]; then cmd_nonfatal $REMOTE "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt" echo "Getting remote dmesg" - cmd $REMOTE sudo dmesg "${tmpdir}/${results}/kernel_log.txt" + cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt" else echo "Verifying that CBMEM is available" if [ $(id -u) -ne 0 ]; then @@ -403,7 +403,7 @@ else cmd_nonfatal $LOCAL "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt" echo "Getting local dmesg" - cmd $LOCAL dmesg "${tmpdir}/${results}/kernel_log.txt" + cmd $LOCAL "sudo dmesg" "${tmpdir}/${results}/kernel_log.txt" fi # -- cgit v1.2.3