From e83e090b05b6aa0d8c1816e626836f712ecb9490 Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Wed, 13 Jul 2022 17:40:30 +0200 Subject: lint/checkpatch: Add a check for existence of a commit log This reduce the difference with linux v5.19-rc7. Signed-off-by: Elyes Haouas Change-Id: I4e3b98140d900c5717f4badde71c7be88fd1e23a Reviewed-on: https://review.coreboot.org/c/coreboot/+/65835 Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth --- util/lint/checkpatch.pl | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'util') diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 7f124525f2e8..86fc9b25c217 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -2454,6 +2454,7 @@ sub process { my $in_commit_log = 0; #Scanning lines before patch my $has_patch_separator = 0; #Found a --- line my $has_commit_log = 0; #Encountered lines before patch + my $commit_log_lines = 0; #Number of commit log lines my $commit_log_possible_stack_dump = 0; my $commit_log_long_line = 0; my $commit_log_has_diff = 0; @@ -2723,6 +2724,18 @@ sub process { $cnt_lines++ if ($realcnt != 0); +# Verify the existence of a commit log if appropriate +# 2 is used because a $signature is counted in $commit_log_lines + if ($in_commit_log) { + if ($line !~ /^\s*$/) { + $commit_log_lines++; #could be a $signature + } + } elsif ($has_commit_log && $commit_log_lines < 2) { + WARN("COMMIT_MESSAGE", + "Missing commit description - Add an appropriate one\n"); + $commit_log_lines = 2; #warn only once + } + # Check if the commit log has what seems like a diff which can confuse patch if ($in_commit_log && !$commit_log_has_diff && (($line =~ m@^\s+diff\b.*a/([\w/]+)@ && -- cgit v1.2.3