OvmfPkg/IoMmuDxe: IoMmuAllocateBuffer(): nicer and more informative DEBUGs

Log all relevant IN and IN OUT parameters on entry.

(Note that the HostAddress parameter is IN OUT rather than OUT due to
historical reasons. The "IN EFI_ALLOCATE_TYPE Type" parameter is now to be
ignored, but historically it could be set to AllocateMaxAddress for
example, and for that HostAddress had to be IN OUT.)

When exiting with success, log all relevant OUT parameters (i.e.,
HostAddress). Also log the new (internal) StashBuffer address, on which
IoMmuMap() and IoMmuUnmap() rely on, for BusMasterCommonBuffer operations
(in-place decryption and encryption, respectively).

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
Tested-by: Brijesh Singh <brijesh.singh@amd.com>

1 files changed, 11 insertions, 2 deletions

diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c
index a153d250d5..0ab7043498 100644
--- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c
+++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c
@@ -490,6 +490,15 @@ IoMmuAllocateBuffer (
   UINTN                     CommonBufferPages;

   COMMON_BUFFER_HEADER      *CommonBufferHeader;

 

+  DEBUG ((

+    DEBUG_VERBOSE,

+    "%a: MemoryType=%u Pages=0x%Lx Attributes=0x%Lx\n",

+    __FUNCTION__,

+    (UINT32)MemoryType,

+    (UINT64)Pages,

+    Attributes

+    ));

+

   //

   // Validate Attributes

   //

@@ -566,10 +575,10 @@ IoMmuAllocateBuffer (
 

   DEBUG ((

     DEBUG_VERBOSE,

-    "%a Address 0x%Lx Pages 0x%Lx\n",

+    "%a: Host=0x%Lx Stash=0x%p\n",

     __FUNCTION__,

     PhysicalAddress,

-    (UINT64)Pages

+    StashBuffer

     ));

   return EFI_SUCCESS;