diff options
| author | Pierre Gondois <Pierre.Gondois@arm.com> | 2021-01-15 17:07:16 +0000 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2021-04-15 19:53:39 +0000 |
| commit | dc6c6397b8ae1ba908bc8ed2a0c71b8c13b7c6a3 (patch) | |
| tree | 2a37a6e43dc8d2939090296de6443b3948e30848 | |
| parent | 68c1868565cd38f045dfd6e686588b5d44c1dc97 (diff) | |
| download | edk2-dc6c6397b8ae1ba908bc8ed2a0c71b8c13b7c6a3.tar.gz edk2-dc6c6397b8ae1ba908bc8ed2a0c71b8c13b7c6a3.tar.bz2 edk2-dc6c6397b8ae1ba908bc8ed2a0c71b8c13b7c6a3.zip | |
ArmPkg: Fix Ecc error 8005 for SCMI_STATUS
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
| -rw-r--r-- | ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 2 | ||||
| -rw-r--r-- | ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 22 |
2 files changed, 12 insertions, 12 deletions
diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c index 25f6cc3371..a1bf1b95c0 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c +++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c @@ -123,7 +123,7 @@ ScmiCommandExecute ( Response = (SCMI_MESSAGE_RESPONSE*)MtlGetChannelPayload (Channel);
- if (Response->Status != SCMI_SUCCESS) {
+ if (Response->Status != ScmiSuccess) {
DEBUG ((DEBUG_ERROR, "SCMI error: ProtocolId = 0x%x, MessageId = 0x%x, error = %d\n",
Command->ProtocolId,
Command->MessageId,
diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h index 6de57a5c95..118961dbe2 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h @@ -30,17 +30,17 @@ typedef enum { // SCMI response error codes.
typedef enum {
- SCMI_SUCCESS = 0,
- SCMI_NOT_SUPPORTED = -1,
- SCMI_INVALID_PARAMETERS = -2,
- SCMI_DENIED = -3,
- SCMI_NOT_FOUND = -4,
- SCMI_OUT_OF_RANGE = -5,
- SCMI_BUSY = -6,
- SCMI_COMMS_ERROR = -7,
- SCMI_GENERIC_ERROR = -8,
- SCMI_HARDWARE_ERROR = -9,
- SCMI_PROTOCOL_ERROR = -10
+ ScmiSuccess = 0,
+ ScmiNotSupported = -1,
+ ScmiInvalidParameters = -2,
+ ScmiDenied = -3,
+ ScmiNotFound = -4,
+ ScmiOutOfRange = -5,
+ ScmiBusy = -6,
+ ScmiCommsError = -7,
+ ScmiGenericError = -8,
+ ScmiHardwareError = -9,
+ ScmiProtocolError = -10
} SCMI_STATUS;
// SCMI message IDs common to all protocols.
|