summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGetnat Ejigu <getnatejigu@gmail.com>2021-04-30 14:07:49 -0700
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2021-05-04 00:51:20 +0000
commitf297b7f20010711e36e981fe45645302cc9d109d (patch)
tree0a09fd05d88d9964f5ffb6f10f9e3eaf2f96e065
parent8c8f49f0dc86e3c58d94766e6b194b83c1bef5c9 (diff)
downloadedk2-f297b7f20010711e36e981fe45645302cc9d109d.tar.gz
edk2-f297b7f20010711e36e981fe45645302cc9d109d.tar.bz2
edk2-f297b7f20010711e36e981fe45645302cc9d109d.zip
UnitTestFrameworkPkg: Sample unit test hangs when running in OVMF/QEMU
Sample unit tests in UnitTestFrameworkPkg hangs when running in OVMF/QEMU environment. Build target is X64/GCC5. Fixing this issue by adding EFIAPI to ReportPrint() function that use VA_ARGS. Signed-off-by: Getnat Ejigu <getnatejigu@gmail.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
-rw-r--r--UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c1
-rw-r--r--UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c1
-rw-r--r--UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c1
-rw-r--r--UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c1
4 files changed, 4 insertions, 0 deletions
diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
index 3669d63701..9a74016456 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c
@@ -42,6 +42,7 @@ AddUnitTestFailure (
STATIC
VOID
+EFIAPI
UnitTestLogFailure (
IN FAILURE_TYPE FailureType,
IN CONST CHAR8 *Format,
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
index 66c9db457d..7f7443a233 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
index cfb0c5972b..db5402d6a2 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibConOut.c
@@ -12,6 +12,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...
diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
index 1402d0ef83..1d62c6a371 100644
--- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
+++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLibDebugLib.c
@@ -11,6 +11,7 @@
#include <Library/DebugLib.h>
VOID
+EFIAPI
ReportPrint (
IN CONST CHAR8 *Format,
...