summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPierre Gondois <Pierre.Gondois@arm.com>2021-04-20 14:04:04 +0100
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2021-04-28 12:03:51 +0000
commitfd9cc2052e230742279edf5fa0a56159a19ef23c (patch)
tree6d44d3823534af664b9b52e99e1db03b3e6482fe
parentcc15a619a6fe527b6a00cbea3a0359a9c9c8602b (diff)
downloadedk2-fd9cc2052e230742279edf5fa0a56159a19ef23c.tar.gz
edk2-fd9cc2052e230742279edf5fa0a56159a19ef23c.tar.bz2
edk2-fd9cc2052e230742279edf5fa0a56159a19ef23c.zip
ArmPkg: Fix Ecc error 3002 in StandaloneMmMmuLib
This patch fixes the following Ecc reported error: Non-Boolean comparisons should use a compare operator (==, !=, >, < >=, <=) Cc: Bret Barkelew <bret.barkelew@microsoft.com> Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Sami Mujawar <sami.mujawar@arm.com> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
-rw-r--r--ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
index 5f453d18e4..31672ae5cf 100644
--- a/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
+++ b/ArmPkg/Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c
@@ -101,7 +101,7 @@ SendMemoryPermissionRequest (
}
// Check error response from Callee.
- if (*RetVal & BIT31) {
+ if ((*RetVal & BIT31) != 0) {
// Bit 31 set means there is an error retured
// See [1], Section 13.5.5.1 MM_SP_MEMORY_ATTRIBUTES_GET_AARCH64 and
// Section 13.5.5.2 MM_SP_MEMORY_ATTRIBUTES_SET_AARCH64.