diff options
| author | Chris Jones <christopher.jones@arm.com> | 2021-12-14 20:37:36 +0800 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2022-02-07 01:52:17 +0000 |
| commit | 6fb09da89f88000a7592171a0ce08cf1feaa0646 (patch) | |
| tree | b786a8a7366883fc22cac8db5134de11af747799 /ShellPkg | |
| parent | a4b7aa362d94bbe0287663cab9af4ab503f6185d (diff) | |
| download | edk2-6fb09da89f88000a7592171a0ce08cf1feaa0646.tar.gz edk2-6fb09da89f88000a7592171a0ce08cf1feaa0646.tar.bz2 edk2-6fb09da89f88000a7592171a0ce08cf1feaa0646.zip | |
ShellPkg: Fix incorrect PPTT FlagName dereference
Bugzilla: 3770 (https://bugzilla.tianocore.org/show_bug.cgi?id=3770)
The PPTT parser in AcpiView incorrectly dereferences a pointer to
FlagName when trying to log an error with the PPTT cache flags, which
can lead to random crashes and other errors.
Also fix some spacing in the error message to ensure the message is
printed cleanly.
Signed-off-by: Chris Jones <christopher.jones@arm.com>
Reviewed-by: Rebecca Cran <rebecca@nuviainc.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Diffstat (limited to 'ShellPkg')
| -rw-r--r-- | ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c index 8d52bb5e48..5377764458 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c @@ -40,9 +40,9 @@ LogCacheFlagError ( IncrementErrorCount ();
Print (
L"\nERROR: On Arm based systems, all cache properties must be"
- L"provided in the cache type structure."
- L"Missing '%s' flag.",
- *FlagName
+ L" provided in the cache type structure."
+ L" Missing '%s' flag.",
+ FlagName
);
}
|